Skip to content

Bundle operations take 2 #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 25, 2025
Merged

Bundle operations take 2 #6965

merged 16 commits into from
May 25, 2025

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented May 14, 2025

No description provided.

@fil512 fil512 requested review from tadgh and AD1306 as code owners May 14, 2025 19:09
@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@codecov Codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (112cec3) to head (1e1d53f).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6965   +/-   ##
=========================================
  Coverage     83.41%   83.41%           
- Complexity    29193    29220   +27     
=========================================
  Files          1843     1844    +1     
  Lines        113422   113488   +66     
  Branches      14251    14259    +8     
=========================================
+ Hits          94608    94664   +56     
- Misses        12730    12733    +3     
- Partials       6084     6091    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

TipzCM
TipzCM approved these changes May 22, 2025
View reviewed changes
@robogary
Copy link
Contributor

[spotless]: This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

tadgh
tadgh approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@tadgh tadgh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending one question

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@robogary
Copy link
Contributor

[spotless]: Formatting check succeeded!

@tadgh tadgh merged commit c844c3f into master May 25, 2025
65 checks passed
@tadgh tadgh deleted the khs-20250514-bundle-operations-2 branch May 25, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadgh tadgh tadgh approved these changes

@TipzCM TipzCM TipzCM approved these changes

@AD1306 AD1306 Awaiting requested review from AD1306 AD1306 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fil512 @robogary @tadgh @TipzCM