Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build circle-cycle out of multiple arcs #2375

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Build circle-cycle out of multiple arcs #2375

merged 2 commits into from
Jun 7, 2024

Conversation

hannobraun
Copy link
Owner

Please refer to the documentation this pull requests updates, #2290 (comment), and #2374 for information on why this is necessary.

This is another step towards #2290.

See the updated documentation for motivation.
Per the previous commit, it no longer creates valid geometry.
@hannobraun hannobraun enabled auto-merge June 6, 2024 17:56
@hannobraun
Copy link
Owner Author

This fails with a panic, but only on Windows. I don't understand why. This is a comparison against a tolerance value, and the actual value is not even close to it. The difference is much too distinct to be explained by varying floating point precision between the different test runners.

Not sure what this is about. I'll look into it.

This was referenced Jun 7, 2024
@hannobraun hannobraun merged commit 9033890 into main Jun 7, 2024
3 of 4 checks passed
@hannobraun hannobraun deleted the circle branch June 7, 2024 19:11
@hannobraun
Copy link
Owner Author

I've decided to work around this issue by disabling the CI build on Windows. See #2376 for details.

The Windows part of the CI build is being disabled in #2377. I meant to merge that first, then rebase and merge this pull request afterwards. But when I went into the repository configuration, to update the branch protection settings to no longer require the Windows build, this got merged automatically, as it was still set to "auto-merge" from yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant