Remove redundant geometry from HalfEdge
#2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-edge geometry is supposed to be stored per-object, which is what this commit achieves. Previously, it would have been overwritten, if an object that happened to be equal was stored. This bug doesn't manifest so far, because the geometry that is stored is still redundantly part of `HalfEdge` itself, so you'd never overwrite something that wasn't equal anyway. This will change, of course, as soon as the redundant geometry definition in `HalfEdge` is removed. This is one of those colossally stupid bugs that shouldn't have happend in the first place. It's good though, because it helped me realize two things: 1. The distinction between `Handle` and `HandleWrapper` is a footgun. 2. That distinction is also no longer necessary. With geometry being stored in a dedicated layer, the times of needing to compare objects for equality are coming to and end. There is simply no reason to ever expect to objects to be equal, if they aren't also identical. This means, it should be possible to make `Handle` behave like `HandleWrapper`, replace `HandleWrapper` with the new and improved `Handle`, and then remove the `Eq`/`PartialEq` implementations for all objects. Because otherwise, that's another footgun waiting to happen. That's what I'll be doing next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards #2116.