fix(cmake): only set CXX_SCAN_FOR_MODULES on CMake >= 3.28 (#345) - #367
Open
rachelwelchio wants to merge 1 commit into
Open
fix(cmake): only set CXX_SCAN_FOR_MODULES on CMake >= 3.28 (#345)#367rachelwelchio wants to merge 1 commit into
rachelwelchio wants to merge 1 commit into
Conversation
…t#345) Signed-off-by: rachelwelchio <rachelwelchio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guards
CXX_SCAN_FOR_MODULESbehind CMake >= 3.28 so configuring the INTERFACEctretarget works on older CMake (#345).CXX_SCAN_FOR_MODULESwas added in CMake 3.28. Setting it unconditionally also breaks CMake < 3.19 on INTERFACE libraries (non-whitelisted property). Behavior on CMake >= 3.28 is unchanged.Test plan
CTRE_MODULE— should succeedCXX_SCAN_FOR_MODULESstill set to0on the INTERFACE targetCTRE_MODULE=ON) unchangedCloses #345