Skip to content

patch: optimized adding any #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

Andersama
Copy link
Contributor

@Andersama Andersama commented Apr 13, 2021

Instead of inserting, modify the point set to its now equivalent form.

Lowers compilation time, especially on more complex regexs.

@hanickadot
Copy link
Owner

please update it to latest main run make single-header

@Andersama
Copy link
Contributor Author

I updated it to the latest, but I don't have make on my system.

Instead of inserting, modify the point set to its new equivalent form.
@Andersama
Copy link
Contributor Author

@hanickadot worked out how to get make going, think this is what you wanted? Any other pr's you're interested in that I should go back and update?

@hanickadot
Copy link
Owner

I just prefer to not forget about single-header versions, sometimes they divert, and I'm surprised. That's all :)

@hanickadot hanickadot merged commit 871a29c into hanickadot:main Jun 9, 2021
@Andersama
Copy link
Contributor Author

@hanickadot you may want to add #183, although looking at it, I think I forgot to merge if the point was the last in the list. I can't remember if it was this or the other pr which made a bigger difference to compile times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants