fix(ci): clippy/fmt 위반 수정 — PR #95 test 코드 (main 복구)#97
Merged
Conversation
PR #95 (#94 fix) 가 fork PR 이라 CI 가 자동 실행되지 않아 clippy/fmt 위반이 main 에 들어가 main CI 가 failure 상태였음. - `embedding.rs:1011` `texts.iter().map(|s| *s).collect::<Vec<_>>()` → `&texts` (배열→슬라이스 coerce). map_clone + iter_cloned_collect 해소. - 동 test 코드의 fmt 위반 (빈 줄) 정리. 검증: cargo clippy --workspace --all-targets -D warnings + fmt --check 모두 clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reformats the session builder initialization across multiple lines, simplifies a test case by passing a reference directly instead of mapping and collecting, and cleans up minor whitespace. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #95 (#94 fix) 가 fork PR 이라 GitHub 이 maintainer approval 전까지 workflow 를 보류 → CI 미실행으로 clippy/fmt 위반이 main 에 머지됨. main CI 가 failure 상태 (run 26605390207).
Fix
crates/secall-core/src/search/embedding.rstest 코드:texts.iter().map(|s| *s).collect::<Vec<_>>()→&texts(배열→슬라이스 coerce).clippy::map_clone+clippy::iter_cloned_collect해소.Test plan
cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --all -- --checkclean긴급 main 복구용 hotfix 입니다.
🤖 Generated with Claude Code