refactor(ingest): P90 — WIKI_INVOCATION_MARKER 소유권 ingest 로 이전#102
Merged
Conversation
Gemini 리팩토링 보고서 [낮음] 항목: 하위 레이어 ingest 가 상위 레이어 wiki 의 WIKI_INVOCATION_MARKER 를 참조하는 역방향 의존 (논리적 순환) 해소. - marker 정의를 `wiki::` → `ingest::` 로 이전 (노이즈 판정 주체가 owner). - `wiki::mod.rs` 는 `pub use crate::ingest::WIKI_INVOCATION_MARKER` re-export 로 기존 `wiki::WIKI_INVOCATION_MARKER` 참조 (wiki/codex.rs, wiki/claude.rs) 호환 유지. - ingest/mod.rs 의 self-참조 (`crate::wiki::...` → 로컬 상수) + test 2곳 정리. 결과: ingest/ 디렉토리에 `crate::wiki` 참조 0건 (역참조 완전 제거). 동작 변경 없음. 검증 (결과 확인 후 commit): fmt=0, clippy=0, cargo test --workspace=0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the ownership of WIKI_INVOCATION_MARKER by moving its definition from the wiki module to the ingest module, where noise session detection occurs. The wiki module now re-exports this marker to maintain backward compatibility, and internal references within ingest have been updated. I have no feedback to provide as there are no review comments.
Merged
hang-in
added a commit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemini 리팩토링 보고서의 [낮음] 항목 (유일하게 저비용·저위험으로 동의한 항목) 처리. 하위 레이어
ingest가 상위 레이어wiki의 상수를 참조하던 역방향 의존(논리적 순환)을 해소.변경
WIKI_INVOCATION_MARKER정의를wiki::mod.rs→ingest::mod.rs로 이전. 노이즈 판정 주체(ingest)가 marker 의 owner.wiki::mod.rs는pub use crate::ingest::WIKI_INVOCATION_MARKERre-export → 기존wiki::WIKI_INVOCATION_MARKER참조처 (wiki/codex.rs,wiki/claude.rs) 변경 없이 호환.ingest/mod.rs의 self-참조 + test 2곳을 로컬 상수로 정리.효과
ingest/디렉토리에crate::wiki참조 0건 (역참조 완전 제거). 의존 방향: wiki(상위) → ingest(하위) 단방향으로 정리. 동작 변경 없음 (상수 값 동일, re-export 로 모든 호출처 유지).Test plan
cargo fmt --all -- --check= 0cargo clippy --workspace --all-targets -- -D warnings= 0cargo test --workspace --no-fail-fast= 0 (ingest 115 + 전체 green)Note
나머지 보고서 제안 3건(LLM 클라이언트 공통화 / CLI→core service 이전 / SeCallMcpServer 분리)은 비용·위험 대비 현 시점 가치가 낮아 보류 (백로그). 이 PR 은 보고서 + 검토자 모두 "리스크 전무, 국소적"으로 동의한 항목만 처리.
🤖 Generated with Claude Code