Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict pandas and matplotlib versions for conda CI #369

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Mar 5, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #368

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (24cbfa5) to head (55e39d3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         3043      3043           
=========================================
  Hits          3043      3043           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd AdamOrmondroyd added the bug Something isn't working label Mar 5, 2024
@AdamOrmondroyd AdamOrmondroyd changed the title Condapandas restrict pandas version for conda install Mar 5, 2024
@AdamOrmondroyd AdamOrmondroyd changed the title restrict pandas version for conda install restrict pandas and matplotlib versions for conda CI Mar 5, 2024
@AdamOrmondroyd AdamOrmondroyd marked this pull request as ready for review March 5, 2024 13:31
@AdamOrmondroyd
Copy link
Collaborator Author

Can't say I like this at all. @williamjameshandley @lukashergt is there a better way of enforcing conda to use the correct package versions?

@williamjameshandley
Copy link
Collaborator

NAFAIK. conda just works™

Copy link
Collaborator

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @AdamOrmondroyd. LTGM

@AdamOrmondroyd AdamOrmondroyd merged commit 54170d8 into handley-lab:master Mar 5, 2024
38 of 42 checks passed
@AdamOrmondroyd
Copy link
Collaborator Author

Many thanks @AdamOrmondroyd. LTGM

Looks to good me? 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda install ignores pandas version requirements
2 participants