Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add halo-plugin-auto-backup #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add halo-plugin-auto-backup #132

wants to merge 2 commits into from

Conversation

yuxuefenfei
Copy link

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang November 25, 2024 05:20
@yuxuefenfei yuxuefenfei marked this pull request as draft November 25, 2024 05:22
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@yuxuefenfei yuxuefenfei marked this pull request as ready for review November 25, 2024 05:25
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby November 25, 2024 05:25
JohnNiang
JohnNiang approved these changes Nov 26, 2024
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuxuefenfei , thanks for your contribution!

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@JohnNiang
Copy link

/ping @halo-sigs/halo

@ruibaby
Copy link
Member

ruibaby commented Dec 3, 2024

感谢参与贡献，这里有几个问题：

  1. 如果要上架应用市场，请完善 README，至少要包含使用方式和注意事项。
  2. 建议完善插件描述（比如插件用途），而不只是 “一个自动备份插件”，https://github.com/yuxuefenfei/halo-plugin-auto-backup/blob/9d404bb97ad4fd3f2cf9eef208da09061f8d2330/src/main/resources/plugin.yaml#L19C17-L19C19
  3. 建议为插件提供自动清理的功能，比如保留份数，如果没有这个功能且用户设置了一个小时备份一次，那么很可能导致无限备份，最终占满机器磁盘，我们不能假设用户的备份文件大小。并且这种插件的存在感比较低，用户设置完之后很容易意识不到这个问题。

JohnNiang
JohnNiang approved these changes Dec 23, 2024
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ping @halo-sigs/halo

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuxuefenfei @JohnNiang @ruibaby