Support strided store with predicate in SVE2#9085
Open
stevesuzuki-arm wants to merge 3 commits intohalide:mainfrom
Open
Support strided store with predicate in SVE2#9085stevesuzuki-arm wants to merge 3 commits intohalide:mainfrom
stevesuzuki-arm wants to merge 3 commits intohalide:mainfrom
Conversation
Handle the tail of a vector by using predicate while taking predicated store into account
abadams
reviewed
Mar 30, 2026
| Expr vpred_predicated_store; | ||
| const Shuffle *shuffle = rhs.as<Shuffle>(); | ||
| if (shuffle && shuffle->is_interleave() && shuffle->vectors.size() == static_cast<size_t>(num_vecs)) { | ||
| vpred_predicated_store = shuffle->vectors[0]; |
Member
There was a problem hiding this comment.
This only looks at shuffle->vectors[0], and the below takes a slice starting at zero. Doesn't this assume that the predicate is the same for each of the interleaved vectors? I think that would need to be checked.
Contributor
Author
There was a problem hiding this comment.
Right, I've added the checking in the new commit. I'm not sure if using can_prove() is the best way though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strided store with predicated tail strategy is supported by computing
the predicate in SVE2 intrinsic.
Checklist