Skip to content

[query] Remove Azure oauth support from scala query library - #15897

Merged
hail-ci-robot merged 2 commits into
mainfrom
cv/query/rm-azure-oauth
Oct 23, 2026
Merged

hail-ci-robot merged 2 commits into
mainfrom
cv/query/rm-azure-oauth

Conversation

@chrisvittal

Copy link
Copy Markdown
Collaborator

Python support remains.

Security Impact

  • This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP

Stack created with GitHub Stacks CLI • Give Feedback 💬

@chrisvittal
chrisvittal added this pull request to stack #15894 October 21, 2026 20:33
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9186c675-567a-4f86-bbae-eda093d92ce3
📥 Commits

Reviewing files that changed from the base of the PR and between 0076b46 and f668ac6.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d49246b9-c513-4437-93d3-cc64cb2888d4
📥 Commits

Reviewing files that changed from the base of the PR and between 2cb380e and 2d346ec.

📒 Files selected for processing: 5
  • hail/hail/package.mill
  • hail/hail/shadeazure/package.mill
  • hail/hail/src/is/hail/services/oauth2.scala
  • hail/hail/src/is/hail/services/package.scala
  • hail/scripts/test-gcp.sh
💤 Files with no reviewable changes: 3
  • hail/scripts/test-gcp.sh
  • hail/hail/shadeazure/package.mill
  • hail/hail/src/is/hail/services/oauth2.scala

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Azure credential support and Azure-specific error classifications were removed. The Azure shading build module was deleted, and the GCP test script no longer excludes the shaded Azure package.

Changes: Azure Support Removal

Layer / File(s) Summary
Remove Azure credential support
hail/hail/src/is/hail/services/oauth2.scala
HailCredentials no longer accepts Microsoft identities. CloudCredentials now selects Google credentials for missing or gcp values, and Azure credential implementations were removed.
Remove Azure error classifications
hail/hail/src/is/hail/services/package.scala
The retry classifiers no longer unwrap shaded Azure exceptions or match the removed Azure exception types and messages.
Remove Azure shading build module
hail/hail/shadeazure/package.mill, hail/scripts/test-gcp.sh, hail/hail/package.mill
The Azure shading module was deleted. GCP test discovery no longer excludes the shaded Azure package. Whitespace was normalized in package.mill.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: ehigham

Merge Risk: ⚪ Minimal · up to 2d346

The Azure Scala support removal is ready to merge with no identified actionable risk.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description states that Python support remains and includes the required GCP security-impact conclusion. It does not include the required Change Description section or a brief explanation of the A… Add a Change Description section with the issue reference or N/A and a brief summary and justification of the Azure OAuth and shadeazure removals. Use the template heading ## Security Assessment, or explain the security assessment under the…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: removal of Azure OAuth support from the Scala query library.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description states that Python support remains and includes the required GCP security-impact conclusion. It does not include the required Change Description section or a brief explanation of the Azure OAuth and shadeazure removals.

Resolution

Add a Change Description section with the issue reference or N/A and a brief summary and justification of the Azure OAuth and shadeazure removals. Use the template heading ## Security Assessment, or explain the security assessment under the prescribed template structure.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chrisvittal
chrisvittal requested review from ehigham and patrick-schultz and removed request for ehigham October 21, 2026 20:34
@hail-ci-robot
hail-ci-robot force-pushed the cv/query/rm-azure-oauth branch from 2d346ec to a6b7452 Compare October 23, 2026 02:12
@chrisvittal
chrisvittal force-pushed the cv/query/rm-azure-oauth branch from a6b7452 to 0076b46 Compare October 23, 2026 07:25
Base automatically changed from cv/query/rm-azurefs to main October 23, 2026 19:27
@hail-ci-robot
hail-ci-robot force-pushed the cv/query/rm-azure-oauth branch from 0076b46 to f668ac6 Compare October 23, 2026 19:27
@hail-ci-robot
hail-ci-robot merged commit 7f97244 into main Oct 23, 2026
13 checks passed
@hail-ci-robot
hail-ci-robot deleted the cv/query/rm-azure-oauth branch October 23, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants