Repository navigation
[services, hailtop] Revert "shift supported python versions from 3.10-13 to 3.12-14" - #15660
Merged
Merged
Conversation
…-13 to 3…" This reverts commit 8e0548c.
ehigham
approved these changes
Aug 10, 2026
Comment on lines
+62
to
65
| if major_version != 3 or minor_version < 9: | ||
| raise ValueError( | ||
| f'Python versions older than 3.12 (you are using {major_version}.{minor_version}) are not supported' | ||
| f'Python versions older than 3.9 (you are using {major_version}.{minor_version}) are not supported' | ||
| ) |
Contributor
There was a problem hiding this comment.
Inconsistency between minimum Python version checks. This file now requires Python 3.9+ (minor_version < 9), but hail/python/hail/__init__.py requires Python 3.10+, and setup.py/setup-hailtop.py specify python_requires=">=3.10".
# docker.py says 3.9+ is ok:
if major_version != 3 or minor_version < 9:
raise ValueError(f'Python versions older than 3.9...')
# But __init__.py requires 3.10+:
if version_info < (3, 10):
raise EnvironmentError(f'Hail requires Python 3.10...')This should be minor_version < 10 to match the rest of the codebase's 3.10+ requirement.
Suggested change
| if major_version != 3 or minor_version < 9: | |
| raise ValueError( | |
| f'Python versions older than 3.12 (you are using {major_version}.{minor_version}) are not supported' | |
| f'Python versions older than 3.9 (you are using {major_version}.{minor_version}) are not supported' | |
| ) | |
| if major_version != 3 or minor_version < 10: | |
| raise ValueError( | |
| f'Python versions older than 3.10 (you are using {major_version}.{minor_version}) are not supported' | |
| ) | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Collaborator
Author
There was a problem hiding this comment.
this is true but:
- I want a clean roll back to the status quo ante
- This will be fixed when we roll forwards again
sarahgibs
approved these changes
Aug 10, 2026
1 task
ehigham
pushed a commit
to ehigham/hail
that referenced
this pull request
Aug 12, 2026
…0-13 to 3.12-14" (hail-is#15663) Reverts hail-is#15660; restores the changes in hail-is#15603. Should be ready to merge again after the dataproc update (hail-is#15662) --- ## Change Description Updates the default python version to 3.12 and shifts the list of supported versions to 3.12, 3.13, 3.14 to realign with the numpy's supported versions. Update: 3.11 will NOT continue to be supported. EMR has been shown to work ok with 3.12 and numpy support has already expired on 3.11. ## Security Assessment Delete all except the correct answer: - This change potentially impacts the Hail Batch instance as deployed by Broad Institute in GCP ### Impact Rating - This change has a low security impact ### Impact Description Python version updates in services and client libraries. ### Appsec Review - [ ] Required: The impact has been assessed and approved by appsec
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…-13 to 3.12-14" (hail-is#15660) Reverts hail-is#15603 We need 3.11 to support our current dataproc (and spark) version. I will follow up with a PR to do 90% of this again, but keeping 3.11 for now.
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…0-13 to 3.12-14" (hail-is#15663) Reverts hail-is#15660; restores the changes in hail-is#15603. Should be ready to merge again after the dataproc update (hail-is#15662) --- ## Change Description Updates the default python version to 3.12 and shifts the list of supported versions to 3.12, 3.13, 3.14 to realign with the numpy's supported versions. Update: 3.11 will NOT continue to be supported. EMR has been shown to work ok with 3.12 and numpy support has already expired on 3.11. ## Security Assessment Delete all except the correct answer: - This change potentially impacts the Hail Batch instance as deployed by Broad Institute in GCP ### Impact Rating - This change has a low security impact ### Impact Description Python version updates in services and client libraries. ### Appsec Review - [ ] Required: The impact has been assessed and approved by appsec
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…-13 to 3.12-14" (hail-is#15660) Reverts hail-is#15603 We need 3.11 to support our current dataproc (and spark) version. I will follow up with a PR to do 90% of this again, but keeping 3.11 for now.
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…0-13 to 3.12-14" (hail-is#15663) Reverts hail-is#15660; restores the changes in hail-is#15603. Should be ready to merge again after the dataproc update (hail-is#15662) --- ## Change Description Updates the default python version to 3.12 and shifts the list of supported versions to 3.12, 3.13, 3.14 to realign with the numpy's supported versions. Update: 3.11 will NOT continue to be supported. EMR has been shown to work ok with 3.12 and numpy support has already expired on 3.11. ## Security Assessment Delete all except the correct answer: - This change potentially impacts the Hail Batch instance as deployed by Broad Institute in GCP ### Impact Rating - This change has a low security impact ### Impact Description Python version updates in services and client libraries. ### Appsec Review - [ ] Required: The impact has been assessed and approved by appsec
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…-13 to 3.12-14" (hail-is#15660) Reverts hail-is#15603 We need 3.11 to support our current dataproc (and spark) version. I will follow up with a PR to do 90% of this again, but keeping 3.11 for now.
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…0-13 to 3.12-14" (hail-is#15663) Reverts hail-is#15660; restores the changes in hail-is#15603. Should be ready to merge again after the dataproc update (hail-is#15662) --- ## Change Description Updates the default python version to 3.12 and shifts the list of supported versions to 3.12, 3.13, 3.14 to realign with the numpy's supported versions. Update: 3.11 will NOT continue to be supported. EMR has been shown to work ok with 3.12 and numpy support has already expired on 3.11. ## Security Assessment Delete all except the correct answer: - This change potentially impacts the Hail Batch instance as deployed by Broad Institute in GCP ### Impact Rating - This change has a low security impact ### Impact Description Python version updates in services and client libraries. ### Appsec Review - [ ] Required: The impact has been assessed and approved by appsec
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…-13 to 3.12-14" (hail-is#15660) Reverts hail-is#15603 We need 3.11 to support our current dataproc (and spark) version. I will follow up with a PR to do 90% of this again, but keeping 3.11 for now.
kush-chandra
pushed a commit
to kush-chandra/hail
that referenced
this pull request
Aug 19, 2026
…0-13 to 3.12-14" (hail-is#15663) Reverts hail-is#15660; restores the changes in hail-is#15603. Should be ready to merge again after the dataproc update (hail-is#15662) --- ## Change Description Updates the default python version to 3.12 and shifts the list of supported versions to 3.12, 3.13, 3.14 to realign with the numpy's supported versions. Update: 3.11 will NOT continue to be supported. EMR has been shown to work ok with 3.12 and numpy support has already expired on 3.11. ## Security Assessment Delete all except the correct answer: - This change potentially impacts the Hail Batch instance as deployed by Broad Institute in GCP ### Impact Rating - This change has a low security impact ### Impact Description Python version updates in services and client libraries. ### Appsec Review - [ ] Required: The impact has been assessed and approved by appsec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #15603
We need 3.11 to support our current dataproc (and spark) version.
I will follow up with a PR to do 90% of this again, but keeping 3.11 for now.