Repository navigation
[actions] run GHA quick checks in stacks, selectively - #15657
cjllanwarne wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new gating logic can unexpectedly skip checks due to a non-existent mergeable label and can also mask failures if the should-run job fails (workflow may go green incorrectly).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the “Static Analysis and Unit Tests” GitHub Actions workflow to selectively run the “quick checks” for PRs that are part of GitHub stacks, skipping intermediate stack PRs, and to adjust the target SHA used by service checks for stacked PRs.
Changes:
- Add a
should-runjob that decides whether the rest of the quick-check jobs should execute. - Gate most jobs behind
needs: should-run+if: needs.should-run.outputs.run == 'true'. - For
check-services, use the stack’s ultimate base SHA (when present) to improve diffing behavior.
File summaries
| File | Description |
|---|---|
| .github/workflows/static-and-unit-tests.yml | Adds should-run gating logic, updates check-services target SHA selection for stacks, and updates gate behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
patrick-schultz
left a comment
There was a problem hiding this comment.
What's the motivation for this? To save GHA usage? If the purpose of these actions is to give the developer feedback, I feel like that rationale applies equally to the entire stack.
|
@patrick-schultz yes, basically. This came about because I saw some slowdowns and dropped actions when I |
|
Will revisit if this becomes a recurring problem. |
Change Description
Only impacts PRs which are part of github stacks. Automatically skips the actions if the PR is not the head.
Note: these checks are not official gating checks. They are quick version of actions which also happen in the full CI run, to give faster feedback. So skipping them on intermediate commits is fine.
Security Assessment