Skip to content

HCK-13271: column comment #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

HCK-13271: column comment #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions forward_engineering/configs/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,6 @@ module.exports = {
alterTableAddConstraint: 'ALTER TABLE IF EXISTS ${tableName} ADD ${statement};',
alterTableDropNamedConstraint: 'ALTER TABLE IF EXISTS ${tableName} DROP CONSTRAINT ${constraintName};',
alterTableDropStatement: 'ALTER TABLE IF EXISTS ${tableName} DROP ${statement};',

columnComment: 'COMMENT ON COLUMN ${fullName} IS ${comment}',
};
14 changes: 7 additions & 7 deletions forward_engineering/helpers/alterScriptHelpers/alterEntityHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const getAddCollectionScript =
const { schemaName, databaseName } = getBaseAndContainerNames(collection, getName);
const jsonSchema = {
...collection,
...(_.omit(collection?.role, 'properties') || {}),
..._.omit(collection?.role, 'properties'),
};
const columnDefinitions = _.toPairs(jsonSchema.properties).map(([name, column]) =>
createColumnDefinitionBySchema({
Expand Down Expand Up @@ -47,7 +47,7 @@ const getAddCollectionScript =
const getDeleteCollectionScript = collection => {
const jsonData = {
...collection,
...(_.omit(collection?.role, 'properties') || {}),
..._.omit(collection?.role, 'properties'),
};
const { schemaName, databaseName, tableName } = getNames(jsonData, getName, getEntityName);
const fullName = getFullName(databaseName, getFullName(schemaName, tableName));
Expand All @@ -66,7 +66,7 @@ const getAddColumnScript =
collection => {
const collectionSchema = {
...collection,
...(_.omit(collection?.role, 'properties') || {}),
..._.omit(collection?.role, 'properties'),
};
const { schemaName, databaseName, tableName } = getNames(collectionSchema, getName, getEntityName);
const fullName = getFullName(databaseName, getFullName(schemaName, tableName));
Expand All @@ -92,7 +92,7 @@ const getAddColumnScript =
const getDeleteColumnScript = collection => {
const collectionSchema = {
...collection,
...(_.omit(collection?.role, 'properties') || {}),
..._.omit(collection?.role, 'properties'),
};
const { schemaName, databaseName, tableName } = getNames(collectionSchema, getName, getEntityName);
const fullName = getFullName(databaseName, getFullName(schemaName, tableName));
Expand Down Expand Up @@ -165,9 +165,9 @@ const getModifyColumnScript =

// new or modified comment
if (oldComment !== comment) {
return assignTemplates(templates.alterTable, {
name: fullName,
action: `MODIFY COLUMN ${columnName} COMMENT = ${escapeString(scriptFormat, comment)}`,
return assignTemplates(templates.columnComment, {
fullName: `${fullName}.${columnName}`,
comment: escapeString(scriptFormat, comment),
});
}
})
Expand Down