Skip to content

HCK-11191: Remove logging of system info #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

HCK-11191: Remove logging of system info #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions forward_engineering/helpers/applyToInstanceHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const vm = require('vm');
const bson = require('bson');
const connectionHelper = require('../../shared/mongoDbClient');
const { createLogger, getSystemInfo } = require('../../shared/logHelper');
const { createLogger } = require('../../shared/logHelper');
const readNdJsonByLine = require('./ndJsonHelper');
const { getError } = require('../../shared/getError');

Expand All @@ -16,7 +16,6 @@ const applyToInstanceHelper = {

try {
logger.clear();
log.info(getSystemInfo(data.appVersion));
log.info(data);

const connection = await connectionHelper.connect(data, sshService);
Expand Down Expand Up @@ -53,7 +52,6 @@ const applyToInstanceHelper = {

try {
logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo, 'connectionInfo');

await connectionHelper.connect(connectionInfo, sshService);
Expand Down
4 changes: 1 addition & 3 deletions reverse_engineering/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const async = require('async');
const bson = require('bson');
const connectionHelper = require('../shared/mongoDbClient');
const { createLogger, getSystemInfo } = require('../shared/logHelper');
const { createLogger } = require('../shared/logHelper');
const { getDocDbClientInstance } = require('../shared/getDocDbClientInstance');

module.exports = {
Expand All @@ -21,7 +21,6 @@ module.exports = {

try {
logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo, 'connectionInfo');

await connectionHelper.connect(connectionInfo, sshService);
Expand All @@ -48,7 +47,6 @@ module.exports = {

try {
logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo, 'connectionInfo');

const docDbClientInstance = await getDocDbClientInstance({
Expand Down
46 changes: 0 additions & 46 deletions shared/logHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,3 @@
const os = require('os');
const packageFile = require('../package.json');

const getPluginVersion = () => packageFile.version;

const getSystemInfo = appVersion => {
return (
'' +
`Date: ${new Date()}` +
'\n' +
`Application version: ${appVersion}` +
'\n' +
`Plugin version: ${getPluginVersion()}` +
'\n\n' +
`System information:` +
'\n' +
` Hostname: ${os.hostname()}` +
'\n' +
` Platform: ${os.platform()} ${os.arch()}` +
'\n' +
` Release: ${os.release()}` +
'\n' +
` Uptime: ${toTime(os.uptime())}` +
'\n' +
` Total RAM: ${(os.totalmem() / 1073741824).toFixed(2)} GB` +
'\n' +
` CPU Model: ${os.cpus()[0].model}` +
'\n' +
` CPU Clock: ${maxClock(os.cpus())} MHZ` +
'\n' +
` CPU Cores: ${os.cpus().length} cores` +
'\n\n'
);
};

const maxClock = cpus => {
return cpus.reduce((highestClock, cpu) => Math.max(highestClock, cpu.speed), 0);
};

const prefixZero = number => (number < 10 ? '0' + number : number);

const toTime = number => {
return Math.floor(number / 3600) + ':' + prefixZero(parseInt((number / 3600 - Math.floor(number / 3600)) * 60));
};

const createLogger = ({ title, logger, hiddenKeys }) => {
return {
info(message, infoTitle) {
Expand Down Expand Up @@ -71,5 +26,4 @@ const createError = error => {

module.exports = {
createLogger,
getSystemInfo,
};