-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new iam user for self @here #92
base: main
Are you sure you want to change the base?
Conversation
resolves error 404 on ops-leads group
Terraform plan in terraform Plan: 3 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
Terraform will perform the following actions:
# module.iam_oidc_gha_incubator.aws_iam_role.github_actions_oidc will be updated in-place
!~ resource "aws_iam_role" "github_actions_oidc" {
!~ assume_role_policy = jsonencode(
!~ {
!~ Statement = [
!~ {
!~ Condition = {
!~ StringLike = {
!~ "token.actions.githubusercontent.com:sub" = "*************************************************************************"
}
# (1 unchanged attribute hidden)
}
# (3 unchanged attributes hidden)
},
]
# (1 unchanged attribute hidden)
}
)
id = "gha-incubator"
name = "gha-incubator"
tags = {}
# (11 unchanged attributes hidden)
}
# module.iam_user_herehfla.aws_iam_user.user will be created
+ resource "aws_iam_user" "user" {
+ arn = (known after apply)
+ force_destroy = false
+ id = (known after apply)
+ name = "herehfla"
+ path = "/"
+ tags = {
+ "Access Level" = "1"
+ "Project" = "devops-security"
}
+ tags_all = {
+ "Access Level" = "1"
+ "Project" = "devops-security"
}
+ unique_id = (known after apply)
}
# module.iam_user_herehfla.aws_iam_user_group_membership.user_group_membership will be created
+ resource "aws_iam_user_group_membership" "user_group_membership" {
+ groups = [
+ "read-only-group",
]
+ id = (known after apply)
+ user = "herehfla"
}
# module.iam_user_herehfla.aws_iam_user_login_profile.user_login will be created
+ resource "aws_iam_user_login_profile" "user_login" {
+ encrypted_password = (known after apply)
+ id = (known after apply)
+ key_fingerprint = (known after apply)
+ password = (known after apply)
+ password_length = 20
+ password_reset_required = true
+ user = "herehfla"
}
Plan: 3 to add, 1 to change, 0 to destroy. 📝 Plan generated in Write Terraform Plan to Pull Request #65 |
terraform/aws-users.tf
Outdated
@@ -149,7 +149,7 @@ module "iam_user_alexe" { | |||
"Project" = "devops-security" | |||
"Access Level" = "1" | |||
} | |||
user_groups = ["ops-leads"] | |||
user_groups = ["read-only-group"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user_groups = ["read-only-group"] | |
user_groups = ["ops-leads"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @here this needs to be its original value of 'ops-leads'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted this change with 1aa4e8c , thanks for confirming.
Automatically updated on terraform init Docs at https://developer.hashicorp.com/terraform/language/files/dependency-lock
All known feedback resolved, ready for review and merge.
devops-security/terraform/state.config
$ terraform init -backend-config="./state.config" $ terraform plan
Note that
|
Fixes #77
What changes did you make?
User alexe role changed from ops-leads to read-only-group to avoid terraform apply 404 error on group ops-leadsWhy did you make the changes (we will use this info to test)?