Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mvp terraform config for aws iam resources #1

Merged
merged 11 commits into from
Feb 8, 2024
Merged

Conversation

chelseybeck
Copy link
Member

@chelseybeck chelseybeck commented Jan 18, 2024

Resolves this issue

This is a minimum configuration for using Terraform to create IAM resources in AWS. Apologies for the long PR, but w/ this initial setup it just made sense to do it all at once. 😸

Overview:

View the branch


This is now a working solution. If an apply ran right now, it would create a new group with readonly permissions, create a user 'gwenstacy', and assign the user to the group. I'd like to get this merged to main as a basis for adding resources.

Screenshot 2024-02-01 at 10 15 07 PM Screenshot 2024-02-01 at 10 15 34 PM

@chelseybeck chelseybeck changed the title adding example terraform config for aws iam resources draft: adding example terraform config for aws iam resources Jan 18, 2024
@chelseybeck chelseybeck changed the title draft: adding example terraform config for aws iam resources adding example terraform config for aws iam resources Jan 18, 2024
@chelseybeck
Copy link
Member Author

@nyarly I'd like your feedback if you have a chance to review...we will discuss more in depth at next ops meeting

terraform/aws-groups.tf Outdated Show resolved Hide resolved
terraform/aws-users.tf Outdated Show resolved Hide resolved
@nyarly
Copy link
Member

nyarly commented Jan 19, 2024

Overall, a really nice skeleton. I'd love to see policies filled in and this started to be applied ASAP.

As a separate issue, modernizing existing config should get recorded, so that the manual references to policies or users that already exist can be removed eventually. Not difficult, just a tedious process of finding users and terraform importing them.

@chelseybeck
Copy link
Member Author

chelseybeck commented Jan 30, 2024

Overall, a really nice skeleton. I'd love to see policies filled in and this started to be applied ASAP.

As a separate issue, modernizing existing config should get recorded, so that the manual references to policies or users that already exist can be removed eventually. Not difficult, just a tedious process of finding users and terraform importing them.

Thanks, @nyarly 😄

Completely agree on all points. I was thinking that importing existing IAM resources would make good issues for members to work on after getting Terraform set up and working on a few first issues

@chelseybeck chelseybeck changed the title adding example terraform config for aws iam resources adding mvp terraform config for aws iam resources Feb 2, 2024
Copy link
Member

@nyarly nyarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real good! 💪

@chelseybeck chelseybeck requested review from brittanyms and removed request for erniep278 February 8, 2024 03:04
@chelseybeck chelseybeck merged commit 4788af4 into main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up MVP Terraform configuration to add new users w/ read only access to AWS
3 participants