-
-
Notifications
You must be signed in to change notification settings - Fork 2
Added script to tally and analyze GitHub issue comments from JSON data #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mixin
Are you sure you want to change the base?
Conversation
…ts, made a table to reprsent the number of comments per issue, and identified the issue with the most comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what to do about this PR. It says 1554 files?? There are a lot of libraries being uploaded here and it would be nice if Jason did a separate PR for the libararies and his work, so I don't have to pick through this. As it is it is too much to go through.
On another note, if Jason is now comfortable doing his code reviews with both ChatGPT and the Code Review check list then there isn't much I can add as a reviewer anymore because he is a more experienced coder than I am. I usually just use ChatGPT. I think it is a better idea if Sandy is his reviewer.
At any rate, I am just approving this PR because it is too big to review. We can merge it if Bonnie is ok with that.
Instructions
|
This comment was marked as duplicate.
This comment was marked as duplicate.
sandy3w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jason,
The script looks really clean and good to go, just some minor confusions on my side.
What is the difference between issue-comments.json and issue_comments.json? I see the YAML file writing to issue-comments.json but the tally script reading from issue_comments.json.
Also, is the script meant to stay as a command line script or does the produced data have chances to be reused?
In addition, I see a lot of parameters in the comments data files, are all of them required or can the data be cleaned up a bit (e.g. removing reactions).
Other than these everything looks good!
Best,
Sandy
…SON and md as well as timestamps in file names and cleaned up directory (re-commiting without personal access token)
sandy3w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyyy Jason,
I think the script is a bit outside of my coding knowledge, but everything looks great from what I can understand lol. The cleaned up version of the comments md file looks nice and seems to definitely save lots of space!
Perhaps just rename some of the files to be a bit more clear?
Otherwise, nothing from me:)
|
Hi Jason,
Remember Sally is your reviewer now. Can you cancel your request please?
Andrew
…On Mon, Oct 27, 2025, 7:07 PM Jason Uranta ***@***.***> wrote:
@JasonUranta <https://github.com/JasonUranta> requested your review on:
#34 <#34> Added
script to tally and analyze GitHub issue comments from JSON data.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6SRH32PWH7J3DKHZUXXOD3Z3FWXAVCNFSM6AAAAACJXOYUD2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGU2DANRVG4ZDQNY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@chinaexpert1 @sandy3w If you agree with me about about merging this PR, can you resolve the "review changes" request and instead approve the changes so I can merge the PR? |
Instructions
|
Fixes #23
Fixes #4
This PR introduces tally-issue-comments.py, a Python script that processes the JSON output from the GitHub REST API to analyze issue comment data. The script counts the total number of unique issues, calculates the total number of comments across all issues, identifies the issue with the most comments, and presents this information in a formatted table showing comment counts per issue. The output provides clear summary statistics followed by a detailed breakdown of comments for each issue number.