Feat/qualifier pages #668
Merged
Feat/qualifier pages #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aligned qualifier nav - use grid system instead of flex box for items
|
Tagging Issue #665 and beginning review now |
LoTerence
approved these changes
Apr 12, 2025
There was a problem hiding this comment.
Looks really great so far! I was going to write this on every file but its easier to put it here 😄 Thanks for doing this Benny!
Right now there is no automatic linting set up, I will have to make an issue to address that. For the time being, could you use the eslint extension on vscode to automatically lint code before your PR? Or run npm run lint in the ./frontend folder. Check the Docs for more info.
Other than that everything looks great! Please carry on and let me know if you have any questions
frontend/src/pages/QualifierPage/components/ProgressIndicator.tsx
Outdated
Show resolved
Hide resolved
|
Last comment: please run |
2 tasks
|
looks great! Thanks for the changes! Please go ahead and merge whenever you are ready 😁 |
bzzz-coding
pushed a commit
to bzzz-coding/CivicTechJobs
that referenced
this pull request
May 5, 2025
* update qualifier page 1 - aligned qualifier nav - use grid system instead of flex box for items * Refactor: update button styles for primary-dark theme * Feat: add ProgressIndicator component and integrate it into QualifierPage2 * Refactor: update border style in QualifierNav component * Refactor: dynamic grid layout in QualifierPage1 for responsive design * Feat: enhance RadioButtonForm to support skill selection callback * Feat: update RadioButtonForm dynamically render skill & experience levels * Add selectCOP and experience levels props to qualifiers * Feat: use context in QualiferPage2 to keep track of chosen experience level * Feat: integrate qualifiers context to manage selected COP in QualifierPage1 * Feat: refactor QualifierPage2 layout and improve skill selection handling * Refactor: - renamed experienceLevels to skills_matrix - refactored to use tw-components/Buttons.tsx & added second style - Ran npm run lint in frontend directory * update tech stack * feat: use new tw-button variant, fix merge --------- Co-authored-by: Terence Lo <[email protected]>
bzzz-coding
added a commit
that referenced
this pull request
May 5, 2025
* Created Checkbox Component with Tailwind * Deleted .scss file and refactored away old Checkbox component * Updated Checkbox * Installed tailwind-merge and implemented cn function * Updated Checkbox with twmerge * Update frontend/src/tw-components/Checkbox.tsx Co-authored-by: Terence Lo <[email protected]> * Update frontend/src/tw-components/Checkbox.tsx Co-authored-by: Terence Lo <[email protected]> * Update frontend/tests/components/Checkbox.test.tsx Co-authored-by: Terence Lo <[email protected]> * Feat/qualifier pages (#668) * update qualifier page 1 - aligned qualifier nav - use grid system instead of flex box for items * Refactor: update button styles for primary-dark theme * Feat: add ProgressIndicator component and integrate it into QualifierPage2 * Refactor: update border style in QualifierNav component * Refactor: dynamic grid layout in QualifierPage1 for responsive design * Feat: enhance RadioButtonForm to support skill selection callback * Feat: update RadioButtonForm dynamically render skill & experience levels * Add selectCOP and experience levels props to qualifiers * Feat: use context in QualiferPage2 to keep track of chosen experience level * Feat: integrate qualifiers context to manage selected COP in QualifierPage1 * Feat: refactor QualifierPage2 layout and improve skill selection handling * Refactor: - renamed experienceLevels to skills_matrix - refactored to use tw-components/Buttons.tsx & added second style - Ran npm run lint in frontend directory * update tech stack * feat: use new tw-button variant, fix merge --------- Co-authored-by: Terence Lo <[email protected]> * Fixed className syntax --------- Co-authored-by: Terence Lo <[email protected]> Co-authored-by: Benny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Qualifier Page 1
Qualifier Page 2
Screenshots, if applicable
Qualifier Page 1
Qualifier Page 2