Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7 #3317

Merged
merged 0 commits into from
Jan 17, 2023
Merged

Upgrade to Rails 7 #3317

merged 0 commits into from
Jan 17, 2023

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Dec 15, 2022

Copy of #3261 but with a fresh review app so that #3311 is applied

Fixes #3111

Best reviewed by commits. This PR starts by updating the Rails gem and then fixing a few warnings/errors that were happening on boot. Then we go through a few of the recommended rails 7 migration steps (removing spring, running app:update, updating active storage).

  • Update rails gem from 6.1.7 to 7.0.4
  • Silence net-http warnings by adding to Gemfile
  • Force uri version to 0.10.0 (default version in Ruby 2.7)
  • Update maildown gem
  • Remove spring dependency
  • Ran bin/rails app:update
  • Run ActiveStorage migration added by bin/rails app:update

@garyhtou garyhtou temporarily deployed to bank-hackclu-rails-7-ne-uapxrm December 15, 2022 08:36 Inactive
@albertchae albertchae changed the title rails 7 new review app Upgrade to Rails 7 Dec 15, 2022
@albertchae albertchae force-pushed the rails-7-new-review-app branch from 4341f34 to 5da18a4 Compare January 12, 2023 07:01
@maxwofford maxwofford temporarily deployed to bank-hackclu-rails-7-ne-jg7qa3 January 12, 2023 18:48 Inactive
@albertchae albertchae force-pushed the rails-7-new-review-app branch from 5da18a4 to bac8f15 Compare January 15, 2023 21:33
@albertchae
Copy link
Contributor Author

albertchae commented Jan 15, 2023

Hey @garyhtou, I noticed on a recent rebase + deploy that I was getting this error

 Your lockfile doesn't include a valid resolution.

 You can fix this by regenerating your lockfile or trying to manually editing the bad locked gems to a version that satisfies all dependencies.

 The unmet dependencies are:

 * rails (>= 5.1.0, < 7.0), depended upon lab_tech-0.1.9, unsatisfied by rails-7.0.4

It looks like lab_tech technically doesn't support rails 7. There's an issue for it here RealGeeks/lab_tech#42. Are we still depending on this gem or can we remove it until the next experiment (hopefully the gem is updated by then, or maybe we can take on updating the gem)? I didn't see anything in the codebase when grepping for LabTech but not sure if there's some other way it's being used.

@garyhtou
Copy link
Member

Let's remove lab_tech. thanks for checking!

@albertchae albertchae force-pushed the rails-7-new-review-app branch from bac8f15 to 6295c72 Compare January 17, 2023 06:58
@albertchae albertchae requested a deployment to bank-hackclu-rails-7-ne-jg7qa3 January 17, 2023 06:58 Abandoned
@albertchae albertchae force-pushed the rails-7-new-review-app branch from 6295c72 to e219abe Compare January 17, 2023 06:59
@albertchae albertchae temporarily deployed to bank-hackclu-rails-7-ne-jg7qa3 January 17, 2023 07:00 Inactive
@albertchae albertchae merged this pull request into main Jan 17, 2023
@albertchae albertchae deleted the rails-7-new-review-app branch January 17, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Rails 7
5 participants