Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reorganizes partial template files in the events and hcb_codes directories by moving them into more structured subdirectories for better organization and maintainability.
Changes:
- Organized
eventspartials intoevents/filters/,events/transfers/, andevents/donations/subdirectories - Organized
hcb_codespartials intohcb_codes/transaction_types/andhcb_codes/memo/subdirectories - Updated all references to moved partials across view files, controllers, and service files
Reviewed changes
Copilot reviewed 32 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/brakeman.ignore | Updated security scanner configuration to reflect moved donation partial paths |
| app/views/wise_transfers/new.html.erb | Updated render calls for reorganized transfer-related partials |
| app/views/wires/new.html.erb | Updated render calls for reorganized transfer-related partials |
| app/views/my/reimbursements.html.erb | Updated search filter partial path |
| app/views/invoices/index.html.erb | Updated search filter partial path |
| app/views/increase_checks/new.html.erb | Updated render calls for reorganized transfer-related partials |
| app/views/hcb_codes/transaction_types/_wise_transfer.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_wire.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_unknown.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_stripe_card.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_personal_transaction.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_paypal_transfer.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_invoice.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_increase_check.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_fee_revenue.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_donation.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_disbursement.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_check_deposit.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_check.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_bank_fee.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/transaction_types/_ach_transfer.html.erb | New file: Moved from hcb_codes/ to transaction_types/ subdirectory |
| app/views/hcb_codes/memo/_stream.html.erb | New file: Moved from hcb_codes/ to memo/ subdirectory |
| app/views/hcb_codes/memo/_memo.html.erb | New file: Moved from hcb_codes/ to memo/ subdirectory, updated references to use new path |
| app/views/hcb_codes/memo/_ai.html.erb | New file: Moved from hcb_codes/ to memo/ subdirectory |
| app/views/hcb_codes/_rich_metadata.html.erb | Updated all render calls to use new transaction_types/ subdirectory paths |
| app/views/hcb_codes/_heading.html.erb | Updated render calls for reorganized memo partials |
| app/views/events/transfers/_step_item.erb | New file: Moved from events/ to transfers/ subdirectory |
| app/views/events/transfers/_notify_recipient.html.erb | New file: Moved from events/ to transfers/ subdirectory |
| app/views/events/transfers/_modal.html.erb | New file: Updated to use new transfers/form path |
| app/views/events/transfers/_form.html.erb | New file: Moved from events/ to transfers/ subdirectory |
| app/views/events/transfers/_attach_receipt.html.erb | New file: Moved from events/ to transfers/ subdirectory |
| app/views/events/transfers.html.erb | Updated render calls for reorganized filter and transfer partials |
| app/views/events/team.html.erb | Updated search filter partial path |
| app/views/events/sub_organizations.html.erb | Updated search filter partial path |
| app/views/events/show.html.erb | Updated render call for reorganized transfer modal partial |
| app/views/events/reimbursements.html.erb | Updated search filter partial path |
| app/views/events/new_transfer.html.erb | Updated render call for reorganized transfer form partial |
| app/views/events/ledger.html.erb | Updated render call for reorganized filter partial |
| app/views/events/filters/_search.html.erb | New file: Moved from events/ to filters/ subdirectory |
| app/views/events/filters/_filter_menu.html.erb | New file: Moved from events/ to filters/ subdirectory |
| app/views/events/filters/_filter_cards_menu.html.erb | New file: Moved from events/ to filters/ subdirectory |
| app/views/events/filters/_filter_cards.html.erb | New file: Updated to use new filters/ subdirectory path |
| app/views/events/filters/_filter.html.erb | New file: Updated to use new filters/ subdirectory paths |
| app/views/events/employees.html.erb | Updated search filter partial path |
| app/views/events/donations/_share_page.html.erb | New file: Moved from events/ to donations/ subdirectory |
| app/views/events/donations/_button.html.erb | New file: Moved from events/ to donations/ subdirectory |
| app/views/events/donation_overview.html.erb | Updated render calls for reorganized donation and filter partials |
| app/views/events/card_overview.html.erb | Updated render calls for reorganized filter partials |
| app/views/events/_heading.html.erb | Updated render call for reorganized donation button partial |
| app/views/disbursements/new.html.erb | Updated render calls for reorganized transfer-related partials |
| app/views/disbursements/_form.html.erb | Updated render call for reorganized transfer attach receipt partial |
| app/views/card_grants/card_index.html.erb | Updated search filter partial path |
| app/views/canonical_transactions/_canonical_transaction.html.erb | Updated render calls for reorganized memo partial |
| app/views/canonical_pending_transactions/_canonical_pending_transaction.html.erb | Updated render calls for reorganized memo partial |
| app/views/ach_transfers/new.html.erb | Updated render calls for reorganized transfer-related partials |
| app/views/ach_transfers/_form.html.erb | Updated render calls for reorganized transfer-related partials |
| app/services/receipt_service/extract.rb | Updated partial path for AI memo in turbo stream |
| app/controllers/hcb_codes_controller.rb | Updated partial paths for reorganized memo partial |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sampoder
reviewed
Feb 1, 2026
| <% elsif (ct.local_hcb_code.stripe_card? && ct.subledger&.present?) && event.present? && !OrganizerPosition.role_at_least?(current_user, event, :member) %> | ||
| <%= link_to url_for(ct.local_hcb_code), data: { turbo_frame: "_top", behavior: "modal_trigger", modal: "transaction_details_#{instance}" } do %> | ||
| <%= render "hcb_codes/memo", hcb_code: ct.local_hcb_code, location: "ledger", ledger_instance: instance, force_display_details: defined?(force_display_details) %> | ||
| <%= render "hcb_codes/memo/memo", hcb_code: ct.local_hcb_code, location: "ledger", ledger_instance: instance, force_display_details: defined?(force_display_details) %> |
Member
There was a problem hiding this comment.
could this just be hcb_codes/memo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partials, partials everywhere!
this pr attempts to bring more structure to the
eventsfolder by organizing all the partial componentsi apologize in advance for the branch name git was being weird