[Card Grants] Require agreeing to purpose and CoC to activate#12742
Open
YodaLightsabr wants to merge 3 commits intomainfrom
Open
[Card Grants] Require agreeing to purpose and CoC to activate#12742YodaLightsabr wants to merge 3 commits intomainfrom
YodaLightsabr wants to merge 3 commits intomainfrom
Conversation
| <div class="field field--checkbox mb2"> | ||
| <%= form.check_box :policy, required: true %> | ||
| <%= form.label :policy do %> | ||
| I will abide by the <%= link_to "Code of Conduct", "https://hackclub.com/conduct", target: :_blank %> and understand that fraud will result in a ban |
Contributor
There was a problem hiding this comment.
What in the Code of Conduct applies to spending from a grant? I don't disagree with making them agree to spending terms but I don't think this policy covers our bases appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Users might not be informed about restrictions on their grant. This makes it hard to enforce a consistent fraud policy.
Describe your changes
This PR adds a Code of Conduct checkbox and a conditional purpose checkbox that only renders if the grant's purpose is set.