Skip to content

Conversation

@coliff
Copy link
Member

@coliff coliff commented Apr 1, 2025

Types of changes

  • Add spellcheck GitHub Action (we have the same on H5BP)
  • Change file-extension of build action from yaml to yml for consistency
  • Add text-wrap: balance; CSS to h1 - looks much nicer :-)
  • Fix file extension for gulpfile on README (its mjs, not js)
  • Update Stylelint and config to latest versions
  • Move engines to bottom (best practise)
  • Adds more useful linting scripts
  • Removed gulp-unCSS - no longer supported and no longer works (will look to find an alternative in a separate PR later)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coliff coliff requested a review from roblarsen April 1, 2025 13:27
@coliff
Copy link
Member Author

coliff commented Apr 1, 2025

hmm... build failing to gulp-uncss. We should look to replace it since it's now archived and not been updated in 8 years.
https://github.com/ben-eb/gulp-uncss

@coliff coliff force-pushed the dev/coliff/spring-clean-fix branch from a4d2d55 to 9b046e5 Compare April 1, 2025 13:43
- Add spellcheck GitHub Action (we have the same on H5BP)
- Change file-extension of build action from yaml to yml for consistency
- Add text-wrap: balance; CSS to h1 - looks much nicer :-)
- Fix file extension for gulpfile on README
- Update Stylelint and config to latest versions
- Move engines to bottom (best practise)
- Adds more useful linting scripts

Try Node v18

Update build.yml

Update build.yml

Update build.yml

Update build.yml

Update build.yml
@coliff coliff force-pushed the dev/coliff/spring-clean-fix branch from a247966 to 94106fd Compare April 1, 2025 13:52
Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good stuff.

@roblarsen roblarsen merged commit e02d3c6 into main Apr 9, 2025
6 checks passed
@roblarsen roblarsen deleted the dev/coliff/spring-clean-fix branch April 9, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants