Skip to content

Fix bool filter type to handle None values #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bool filter type to handle None values #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions jsonpath_ng/ext/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,11 @@ def find(self, datum):
found = []
for data in datum:
value = data.value
if isinstance(self.value, int):
if type(self.value) is int:
try:
value = int(value)
except ValueError:
continue
elif isinstance(self.value, bool):
try:
value = bool(value)
except ValueError:
continue

if OPERATOR_MAP[self.op](value, self.value):
found.append(data)
Expand Down
13 changes: 13 additions & 0 deletions tests/test_jsonpath_rw_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,19 @@
["green"],
id="boolean-filter-string-true-string-literal",
),
pytest.param(
"foo[?flag = true].color",
{
"foo": [
{"color": "blue", "flag": True},
{"color": "green", "flag": 2},
{"color": "red", "flag": "hi"},
{"color": "gray", "flag": None},
]
},
["blue"],
id="boolean-filter-with-null",
),
)


Expand Down