Add tensor type #81
Open
Add tensor type #81
+462
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyBourne
had a problem deploying
to
GitLab GPU trigger
GitHub Actions
Error
|
It seems like you haven't finished working on this PR so it has been put back into draft. Please remove the draft status when the PR can run tests without being interrupted. |
EmilyBourne
temporarily deployed
to
GitLab GPU trigger
GitHub Actions
Inactive
EmilyBourne
added
the
Ready to review
EmilyBourne
had a problem deploying
to
GitLab GPU trigger
GitHub Actions
Error
EmilyBourne
force-pushed
the
ebourne_tensor_tools
branch
from
5ea707d to
9e3bd05
Compare
EmilyBourne
force-pushed
the
ebourne_tensor_type
branch
from
a835ed8 to
9a77b48
Compare
EmilyBourne
temporarily deployed
to
GitLab GPU trigger
GitHub Actions
Inactive
EmilyBourne
temporarily deployed
to
GitLab GPU trigger
GitHub Actions
Inactive
gdgirard
reviewed
Feb 11, 2025
| { | ||
| tensor_tools::Vector<int, R_cov, Theta_cov> a; | ||
| tensor_tools::Vector<int, R, Theta> b; | ||
| ddcHelper::get<R_cov>(a) = -6; |
There was a problem hiding this comment.
You use the function get to initialise the value ? I would have imagine a set function ?
There was a problem hiding this comment.
We can also use get to have a write access.
- if
aisconst-qualified thengetcan only provide you a read access, soget<R_cov>(a) = -6would not compile - if not then
getcan provide both read/write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a type to describe tensor objects. Fixes #75 .
This PR is (almost) equivalent to https://gitlab.maisondelasimulation.fr/gysela-developpers/gyselalibxx/-/merge_requests/852
This PR is based off #77 and must be merged after #77