Skip to content

Update GMGPolar usage - #751

Draft
EmilyBourne wants to merge 5 commits into
develfrom
ebourne_gmgpolar_update
Draft

Update GMGPolar usage#751
EmilyBourne wants to merge 5 commits into
develfrom
ebourne_gmgpolar_update

Conversation

@EmilyBourne

Copy link
Copy Markdown
Member

Update GMGPolar usage following SciCompMod/GMGPolar#313. This PR should be updated (to correct the Dockerfile) and merged when GMGPolar is updated.


Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

  • Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
  • Have you updated the CHANGELOG.md ?
  • Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
  • Have you checked that the AUTHORS file is up to date ?
  • Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
  • Do you follow the conventions specified in our coding standards ?

New Feature Submissions

  • Have you added tests for the new functionalities ?
  • Have you documented the new functionalities:
    • API documentation describing the available methods, when each should be used and how to use them ?
    • User-friendly documentation in README files (which may link to the API documentation).
    • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

  • Have you checked that existing tests cover all code after the changes ?
  • Have you checked that existing tests are still passing ?
  • Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

  • Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

@EmilyBourne EmilyBourne added the Do not merge Label for a PR that should not be merged even if it appears to be ready label Aug 14, 2026
@EmilyBourne

Copy link
Copy Markdown
Member Author

@tpadioleau Leaving this PR here so it is possible to update GMGPolar when I am on holiday

@EmilyBourne
EmilyBourne marked this pull request as ready for review August 14, 2026 06:59
@tpadioleau

Copy link
Copy Markdown
Member

@tpadioleau Leaving this PR here so it is possible to update GMGPolar when I am on holiday

We should ask for a new release ? They need to make sure the version in cmake is updated.

@github-actions

Copy link
Copy Markdown

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions
github-actions Bot marked this pull request as draft August 14, 2026 09:18
@EmilyBourne
EmilyBourne marked this pull request as ready for review August 14, 2026 10:56
@EmilyBourne

Copy link
Copy Markdown
Member Author

@tpadioleau Leaving this PR here so it is possible to update GMGPolar when I am on holiday

We should ask for a new release ? They need to make sure the version in cmake is updated.

No rush on my side. I saw you opened a few PRs too. I don't know if you have finished but I imagine you need a release anyway once you're done

@github-actions

Copy link
Copy Markdown

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions
github-actions Bot marked this pull request as draft August 14, 2026 10:58
@EmilyBourne
EmilyBourne marked this pull request as ready for review August 14, 2026 12:00
@github-actions

Copy link
Copy Markdown

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions
github-actions Bot marked this pull request as draft August 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Label for a PR that should not be merged even if it appears to be ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants