Fix missing includes by EmilyBourne · Pull Request #442 · gyselax/gyselalibxx

EmilyBourne · 2025-10-09T08:41:55Z

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
Have you updated the CHANGELOG.md ?
Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
Have you checked that the AUTHORS file is up to date ?
Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
Do you follow the conventions specified in our coding standards ?

New Feature Submissions

Have you added tests for the new functionalities ?
Have you documented the new functionalities:
- API documentation describing the available methods, when each should be used and how to use them ?
- User-friendly documentation in README files (which may link to the API documentation).
- If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

Have you checked that existing tests cover all code after the changes ?
Have you checked that existing tests are still passing ?
Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

EmilyBourne · 2025-10-09T08:42:52Z

@tpadioleau This PR contains the results of the following command:

bin/run_iwyu toolchains/common_toolchains/serial_debug_toolchain.cmake src/ tests/ simulations/ -j 4 --fix; ./bin/indent -d

There will probably be some wrong suggestions but I have pushed as is to help evaluate #435

EmilyBourne · 2025-10-09T10:29:35Z

Updated following updates to run_iwyu

EmilyBourne · 2025-10-09T10:37:02Z


 #include "ddc_aliases.hpp"
 #include "mesh_builder.hpp"
-#include "non_uniform_interpolation_points.hpp"


This removal seems to create compilation problems related to is_non_uniform_interpolation_points_v

tpadioleau · 2025-10-10T09:11:27Z

 #include <ddc/ddc.hpp>
 #include <ddc/kernels/splines.hpp>

+#include <Serial/Kokkos_Serial.hpp>


Should be a private Kokkos header. Does it compile fine ? Some Kokkos headers are protected.

Ah, I only set the impl folder in Kokkos to private

tpadioleau · 2025-10-10T09:11:37Z

+#include <Kokkos_Core.hpp>
+#include <Kokkos_Macros.hpp>
+#include <Kokkos_MinMax.hpp>
+#include <Kokkos_Parallel_Reduce.hpp>


Also private

tpadioleau · 2025-10-10T09:12:27Z


 #include <gtest/gtest.h>

+#include <Kokkos_ExecPolicy.hpp>


Also private

tpadioleau · 2025-10-10T09:13:44Z


 #pragma once
-#include "ddc_aliases.hpp"
+#include <mdspan/mdspan.hpp>


I don't know what is the best way to handle mdspan. Should we consider that Kokkos_Core.hpp brings it ? As Kokkos does for atomics that come from the desul library ?

🤔 I think we might occasionally use mdspan, but I'm not sure why it thinks it's needed here

Interesting:

#include <mdspan/mdspan.hpp> // for layout_right

Same issue in DDC.

tpadioleau · 2025-10-10T09:14:05Z

 #include <ddc/pdi.hpp>

+#include <Kokkos_Core.hpp>
+#include <Kokkos_Layout.hpp>


Not sure if it is private

tpadioleau · 2025-10-10T09:14:31Z

 #include <ddc/ddc.hpp>
 #include <ddc/pdi.hpp>

+#include <Kokkos_Concepts.hpp>


Not sure either if it is private

tpadioleau · 2025-10-10T09:14:49Z

 #include <ddc/ddc.hpp>
+#include <ddc/kernels/splines.hpp>

+#include <Serial/Kokkos_Serial.hpp>


tpadioleau · 2025-10-10T09:14:54Z

 #include <gtest/gtest.h>

+#include <Kokkos_Core.hpp>
+#include <Kokkos_ExecPolicy.hpp>


tpadioleau · 2025-10-10T09:14:58Z

+#include <Kokkos_ExecPolicy.hpp>
+#include <Kokkos_Macros.hpp>
+#include <Kokkos_MinMax.hpp>
+#include <Kokkos_Parallel_Reduce.hpp>


tpadioleau · 2025-10-10T09:15:22Z

+#include <Kokkos_ExecPolicy.hpp>
+#include <Kokkos_Layout.hpp>
+#include <Kokkos_Macros.hpp>
+#include <Kokkos_Parallel.hpp>


tpadioleau · 2025-10-10T09:16:13Z

+
+#include <Kokkos_Core.hpp>
+#include <Kokkos_Macros.hpp>
+#include <stdlib.h>


Weird, why not ? Is there a missing qualification std:: ?

Ah probably:

#include <stdlib.h> // for abs

this may be why I had that abs line

tpadioleau · 2025-10-10T09:17:43Z

-#include <Kokkos_Core.hpp>
+#include <mdspan/mdspan.hpp>
+
 #include <string.h>


I think we should use cstring with std::memset

tpadioleau · 2025-10-10T09:18:26Z

 #include <ddc/ddc.hpp>

-#include <gmock/gmock.h>
+#include <ext/type_traits.h>


Who are you ?

This doesn't help much:

#include <ext/type_traits.h> // for __promote_2

🤔

/home/emily/Code/gyselalibxx/tests/geometryXVx/lagrange_test.cpp:136:61: warning: __gnu_cxx::__promote_2 is defined in <ext/type_traits.h>, which isn't directly #included.

gyselalibxx/tests/geometryXVx/lagrange_test.cpp

Lines 136 to 138 in 1c78d47

LagrangeTest<100> Test_instance_hundred(100, deg, true, [](double x, int d) {

return std::pow(x, d);

});

Then just a limitation of iwyu

tpadioleau · 2025-10-10T09:18:54Z


 #include <gtest/gtest.h>

+#include <math.h>


Missing std:: qualification ?

EmilyBourne commented Oct 9, 2025

View reviewed changes

Comment thread src/collisions/collision_operator.cpp

EmilyBourne commented Oct 9, 2025

View reviewed changes

Comment thread simulations/geometryXY/guiding_centre/guiding_centre.cpp

EmilyBourne force-pushed the ebourne_288_iwyu_fixes branch from 6dcfebe to 08d5fae Compare October 9, 2025 10:28

EmilyBourne commented Oct 9, 2025

View reviewed changes

tpadioleau reviewed Oct 10, 2025

View reviewed changes

EmilyBourne added 3 commits October 14, 2025 08:59

Move back to end

4f32b74

Use Thomas's gist for Kokkos IWYU config

5741e3d

More detail to avoid misunderstanding

f9706fc

EmilyBourne force-pushed the ebourne_288_iwyu_fixes branch from 08d5fae to fc6258f Compare October 14, 2025 09:10

Save suggestions suggested by run_iwyu

085f72f

EmilyBourne force-pushed the ebourne_288_iwyu_fixes branch from fc6258f to 085f72f Compare October 14, 2025 09:15

	LagrangeTest<100> Test_instance_hundred(100, deg, true, [](double x, int d) {
	return std::pow(x, d);
	});

Uh oh!

Conversation

EmilyBourne commented Oct 9, 2025

All Submissions

New Feature Submissions

Changes to Existing Features

Changes to the CI

Uh oh!

EmilyBourne commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

EmilyBourne commented Oct 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants