fix: remove default props from yoga/web #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the release of React 19, the React team also release React 18.3 that adds warnings in order to streamline the upgrade to react 19. Running the yoga/web components on a project with React 18.3 raised the warning suggesting to replace the default props API in favor of the standard ES6+ default parameters relevant links: - https://react.dev/blog/2024/04/25/react-19-upgrade-guide - https://stackoverflow.com/questions/78931633/warning-page-support-for-defaultprops-will-be-removed-from-function-components
lpolon
force-pushed
the
chore/remove-default-props-web
branch
from
aa12461 to
f0ab094
Compare
18 tasks
lpolon
force-pushed
the
chore/remove-default-props-web
branch
from
f0ab094 to
153175b
Compare
lpolon
changed the title
MicaelRodrigues
requested changes
Jan 29, 2025
Assigning to a variable before using the values as defaults to props make these values referentially stable. Props might be used in dependency arrays. In these cases this change avoid unnecessary re-renders.
lpolon
requested review from
flaviafmoraes,
wellhub-gsevla and
matheus-wh
as code owners
Fix Codacy reported issues during CI check.
|
wellhub-gsevla
approved these changes
Feb 3, 2025
flaviafmoraes
approved these changes
Feb 3, 2025
MicaelRodrigues
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
This PR removes React
defaultPropsin favor of js default parametersReact 19 removed the PropTypes and defaultProps for functions (link).
relevant links:
related issues:
#857 (comment)
[Enter the description of your changes]
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍