Improve OutputStream and Writer emulation #10119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Apr 30, 2025
| nullStream.close(); | ||
| try { | ||
| nullStream.write(1); | ||
| fail("Writing to a closed stream should fail."); |
There was a problem hiding this comment.
Worth noting perhaps that StringReader ignores close, and would fail this style of test. This goes against the JRE implementation and javadoc. There may be others that are wrong too.
Definitely not asking for this to be fixed here, just noting it.
Comment on lines
+256
to
+258
| assertThrows(IOException.class, () -> nullWriter.write(42)); | ||
| assertThrows(IOException.class, () -> nullWriter.append('a')); | ||
| assertThrows(IOException.class, () -> nullWriter.append("hola", 1, 2)); |
There was a problem hiding this comment.
These look wrong to me - why should they throw? Should these be later in the test, perhaps after a nullWriter.close()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10123
Add a few convenience methods introduced in Java 11.