Change the way syntax match is executed. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the match is executed based on the hard coded color (which should not be hard coded in the first place, mentioned in issue guns#1), a color code can have multiple matches if the hex code is used for multiple colors. This commit changes the matching as: ' \d+ #[0-9af]+', containing the xterm256 index of the color, so that the highlight class is independant from the used RGB code.
padawin
added a commit
to padawin/xterm-color-table.vim
that referenced
this pull request
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The syntax highlight group is defined based on the RGB code used, which causes problems if 2 colors use the same RGB (e.g. if you redefine xterm ANSI colors in
.Xresources). It can create the following (Note the colors 16, 21 and 51):It can be reproduced by modifying the ANSI colors of the terminal.
This PR makes the highlight independent from the rgb code used, as long as it is an RGB code.
Result afterwards: