Change vertical gap to 4px in beta containers #13126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 871 kB ℹ️ View Unchanged
|
abeddow91
reviewed
Jan 13, 2025
| @@ -128,16 +129,16 @@ const decidePosition = ( | |||
| }; | |||
|
|
|||
| /** Detemines the gap size between components in card layout */ | |||
| const decideGap = (gapSize: GapSize) => { | |||
| const decideGap = (gapSize: GapSize, isBetaContainer: boolean) => { | |||
There was a problem hiding this comment.
Instead of updating the sizing here, could we update the getGapSize function to pass through tiny as the gap size prop (which is 4px)?
Fweddi
force-pushed
the
fp/meta-spacing
branch
2 times, most recently
from
d7acc43 to
2986579
Compare
Fweddi
force-pushed
the
fp/meta-spacing
branch
from
2986579 to
c0ec4c5
Compare
github-actions
bot
removed
the
run_chromatic
Fweddi
force-pushed
the
fp/meta-spacing
branch
2 times, most recently
from
b381d69 to
1e17403
Compare
Fweddi
force-pushed
the
fp/meta-spacing
branch
from
1e17403 to
8a74765
Compare
Fweddi
changed the title
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Fweddi
force-pushed
the
fp/meta-spacing
branch
from
8a74765 to
90ee12c
Compare
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For cards with a vertical layout and belonging to a beta container, reduce the gap between the image and the meta (i.e. comment count) to tiny (4px).
This PR introduces a new condition to the
getGapSizemethod, but the condition is low down in the priority order.This means there will be some exceptions to this condition, e.g. a 'scrollable small' container is a beta container, but prefers a medium size gap. This rule is preferred to the vertical gap rule.
I am unsure if this priority order is correct - would be good to have another pair of eyes.
Why?
Design spec.
Screenshots