#issue1446 : 修复x86 ubuntu16 链接_rdseed64_step找不到问题

[alittlehorse]

修复x86 ubuntu16 链接_rdseed64_step找不到问题
#1446

[alittlehorse]

@guanzhi hello, please run workflow and see cmake result in ios, android or other archs.

[alittlehorse]

Only using gcc and in x86 or x86_64 arch ,we use x86intrin.h. Please review and run workflow.

[zzl360]

@alittlehorse the above line #include "immintrin.h" is also only in x86 or x86_64.
I believe they also need to be under the macro

[alittlehorse]

@zzl360 you are right. done

[zzl360]

my mistake, according to

GmSSL/CMakeLists.txt

Lines 259 to 267 in 2167dda

	option(ENABLE_RDRND "Enable Intel RDRND instructions" OFF)
	if (${CMAKE_SYSTEM_PROCESSOR} MATCHES x86_64)
	set(ENABLE_RDRND ON)
	endif()
	if (ENABLE_RDRND)
	message(STATUS "ENABLE_RDRND")
	list(APPEND src src/rdrand.c)
	set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mrdrnd -mrdseed")
	endif()

this file will be compiled only on x86_64,so no need to use macro

[alittlehorse]

yes, the option ENABLE_RDRND is matched with x86_64.

the link error in #1446 is the same with https://gcc.gnu.org/legacy-ml/gcc-bugs/2015-11/msg01051.html, so the fix as below will work.

#include <immintrin.h>
#if defined(__GNUC__) 
#include <x86intrin.h>
#endif

[zzl360]

weidai11/cryptopp@951d8b9
I think this is better

[alittlehorse]

we should add gcc version check . This is what you mean, right?

#include <immintrin.h>
#if defined(__GNUC__) && (_GNUC_MAJOR__ > 4 || (__GNUC_MAJOR__ == 4 && __GNUC_MINOR__ >= 6))
#include <x86intrin.h>
#endif

[zzl360]

we should add gcc version check . This is what you mean, right?

#include <immintrin.h>
#if defined(__GNUC__) && (_GNUC_MAJOR__ > 4 || (__GNUC_MAJOR__ == 4 && __GNUC_MINOR__ >= 6))
#include <x86intrin.h>
#endif

yes

[alittlehorse]

@zzl360 please review and run workflows

[zzl360]

@zzl360 please review and run workflows

LGTM
I'm not the maintainer of GMSSL,I think the workflow will be run after approvalled.

[alittlehorse]

We'd better replace __GNUC_MAJOR__ with __GNUC__.

#include <immintrin.h>
#if defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6))
#include <x86intrin.h>
#endif

[alittlehorse]

@guanzhi hello， please review and run workflows. @zzl360 thanks to your review

[alittlehorse]

@guanzhi hello, professor guan, please review. thanks a lot

[alittlehorse]

Hello, this issue has appeared several times before, please review and provide corresponding feedback

[alittlehorse]

please merge this pull request. it has appeared several times

[Gitxiaozhu-oss]

请问大佬们怎么解决这个问题的？

[zzl360]

请问大佬们怎么解决这个问题的？

参考这个pr加头文件

[alittlehorse]

@guanzhi Hello, professor guan! Please review and merge this pr. We have seen several issues related to it in the pr.

[alittlehorse]

@guanzhi plz merge this pr to fix issue: #1446