chore: move group form to sbom-groups list page#965
Merged
carlosthe19916 merged 1 commit intoguacsec:mainfrom Mar 13, 2026
Merged
chore: move group form to sbom-groups list page#965carlosthe19916 merged 1 commit intoguacsec:mainfrom
carlosthe19916 merged 1 commit intoguacsec:mainfrom
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRepoints the GroupFormModal import in the SBOM toolbar to the sbom-groups page’s shared component location, effectively relocating the group creation modal to be conceptually owned by the SBOM Groups list rather than the SBOM list. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 61.29% 60.51% -0.78%
==========================================
Files 211 211
Lines 3731 3731
Branches 853 853
==========================================
- Hits 2287 2258 -29
- Misses 1133 1169 +36
+ Partials 311 304 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stanislavsemeniuk
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero code changes, just moving the GroupForm Modal to the Group List page as I think it belongs there and not to the SBOM list page
Although originally it was created in the SBOM List page, the creation of groups can naturally start in the Group List
Summary by Sourcery
Enhancements: