Skip to content

chore: move group form to sbom-groups list page#965

Merged
carlosthe19916 merged 1 commit intoguacsec:mainfrom
carlosthe19916:hotfix/move-form-to-list
Mar 13, 2026
Merged

chore: move group form to sbom-groups list page#965
carlosthe19916 merged 1 commit intoguacsec:mainfrom
carlosthe19916:hotfix/move-form-to-list

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

@carlosthe19916 carlosthe19916 commented Mar 12, 2026

Zero code changes, just moving the GroupForm Modal to the Group List page as I think it belongs there and not to the SBOM list page

Although originally it was created in the SBOM List page, the creation of groups can naturally start in the Group List

Summary by Sourcery

Enhancements:

  • Centralize the GroupFormModal under the SBOM groups page to better align group creation with group management.

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Repoints the GroupFormModal import in the SBOM toolbar to the sbom-groups page’s shared component location, effectively relocating the group creation modal to be conceptually owned by the SBOM Groups list rather than the SBOM list.

File-Level Changes

Change Details Files
Updated GroupFormModal import path so the modal is sourced from the sbom-groups area instead of the sbom-list components.
  • Changed GroupFormModal import in the SBOM toolbar to reference ../sbom-groups/components/group-form
  • Keeps AddToGroupModal import and other toolbar behavior unchanged
  • No behavioral or logic changes; this is a structural/ownership refactor of the component location
client/src/app/pages/sbom-list/sbom-toolbar.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.51%. Comparing base (33e439c) to head (e511eef).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   61.29%   60.51%   -0.78%     
==========================================
  Files         211      211              
  Lines        3731     3731              
  Branches      853      853              
==========================================
- Hits         2287     2258      -29     
- Misses       1133     1169      +36     
+ Partials      311      304       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carlosthe19916 carlosthe19916 added this pull request to the merge queue Mar 13, 2026
Merged via the queue into guacsec:main with commit 6284a29 Mar 13, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this to Done in Trustify Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants