Fix Beets Versions and Move llvmlite to Dep Group#257
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts dependency constraints/config to avoid Beets 2.6 pulling heavy “optional” deps, while making llvmlite truly optional via a Poetry dependency group.
Changes:
- Updated the allowed
beetsversion range inpyproject.toml. - Moved
llvmliteinto a dedicated Poetry dependency group and removed explicitnumpypinning. - Tweaked tox env installation behavior via
PIP_ONLY_BINARYand added a changelog entry.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates Beets version constraint, makes llvmlite an optional group dependency, and adjusts tox env vars for installation behavior. |
| CHANGELOG.md | Documents the fix in the Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #256
Beets 2.6 installations via
pipalso attempt to install many of it's "optional" dependencies, includinglibrosa, which notably requiresnumbaandllvmlite(on many systems it's often a real pain to build wheels for). This even caused issues for the LSIO team and they opted to build Beets from source instead (see linuxserver/docker-beets#146 (comment) and linuxserver/docker-beets@cb16f63).As a temporary fix, in
v1.3.0I originally addedllvmliteas a required dep to overwrite settings and allow for successful dependency builds; however, this then conflicted with certain installs due to the above issue. Fundamentally, this is likely an upstream issue that needs to be properly addressed in Beets. In the meantime, I've moved thellvmlitespecification to its own dependency group to properly make it optional, and have tweaked the Tox settings to allow for successful installation. In addition, thenumpyspecification was also removed as it should not be handled upstream.This PR also fixes an error in the Beets allowed version for 1.3, which does indeed support Beets versions 2.4 and 2.5.
To Do
Documentation (updateREADME.md)CHANGELOG.md)Tests