Skip to content
This repository was archived by the owner on Mar 4, 2024. It is now read-only.

Remove optional $rust_class_name argument from glib_wrapper! #24

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Nov 6, 2020

This is possible now that Gir is updated.

@bilelmoussaoui
Copy link
Member

bilelmoussaoui commented Nov 6, 2020

Was the removal of the $rust_class_name handled by gir ? I can't seem to get them removed by regenerating the gtk4-rs crates

@ids1024
Copy link
Contributor Author

ids1024 commented Nov 6, 2020

#10 made $rust_class_name optional (and make the class wrapper a generic struct). gtk-rs/gir#983 made gir generate code that doesn't pass this.

@bilelmoussaoui
Copy link
Member

Never mind, I had a cached build of gir which caused this. It works fine! thanks

@sdroege
Copy link
Member

sdroege commented Nov 7, 2020

Looks good to me, I'll merge this once gstreamer-rs is updated so we don't end up with something unbuildable for too long

For some reason `glib/src/gobject/auto` doesn't seem to regenerate
automatically...
Crate users who want to access this can use `glib::Class<T>`.
@sdroege
Copy link
Member

sdroege commented Nov 7, 2020

Also fixed gdkx11-sys, see gtk-rs/gir#979

@sdroege sdroege merged commit 1720bcb into gtk-rs:master Nov 7, 2020
@ids1024 ids1024 deleted the class branch November 9, 2020 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants