-
-
Notifications
You must be signed in to change notification settings - Fork 88
glib/translate: take advantage of Rust Option & Result types #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me. Please also rebase on latest master when fixing the remaining comments as that will then give us CI :)
@GuillaumeGomez Your opinion? |
Looks good to me. Just the remaining Thanks @fengalin ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @GuillaumeGomez please first merge the gir PR, and then this here needs to get gir updated and can go in too
@fengalin Please update with gtk-rs/gir#977 and then let's get this in :) |
It's much more convenient to contribute with the new single repo 👍 |
Please use |
@fengalin Good to go? I'll merge once the gstreamer-rs MR is also ready so we don't have things broken for too long :) |
No, it's not. Using |
Just pushed a commit so that you can see what I had to do so far to workaround some issues since running |
I was able to build the examples with all features using last commit (and However, the |
How does it fail? |
Nevermind, I think it's related to mingw not being installed. It failed on master with the same errors. |
@GuillaumeGomez @sdroege I think it's finally good to go! |
Otherwise seems good to me |
All green! |
@sdroege It's good for me, so whenever you want. |
No way! I'm doing the doc changes first :) |
Oh wow. Please do so, don't want to be in the middle XD |
This commit introduces OptionToGlib and TryFromGlib to help with translations from and to Glib types which encode a value with a sentinel to indicate a None value and/or for which some values are invalid. These traits allow auto-implementing Option<T>::to_glib, Option<T>::from_glib or Result::<Option<T>, _>::from_glib from dependent crates when appropriate despite the orphan rule.
This is a fix for issues that appeared since previous commit: - gobject version table is not properly generated. - features dependencies not properly generated for gdkx11-sys. See gtk-rs/gir#979.
Regenerate with latest gir
CI: replace travis with github actions
This is the continuation of gtk-rs/glib#718.
Requires:
gir
submodule + Regenerateatk
,pango
andgtk
.