This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Finish feature "futures-nightly" removal #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh crap, we forgot to remove it... |
sdroege
reviewed
Aug 30, 2018
|
Strange, but gtk-rs/glib#373 builds fine without this. |
|
I wanted to keep as much as possible in place so it can easily be added back later, but I don't really care much. Whatever seems better to you :) |
|
If it works, it works so sounds good to me. |
|
Ok, I close this, as it don't break build, |
EPashkin
force-pushed
the
finish_futures-nightly_removal
branch
from
d01f9bd to
a6e9383
Compare
Merged
|
I merge then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GuillaumeGomez PR in high-probable case that gtk-rs/glib#373 fails again
cc @sdroege