This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Remove futures-nightly from travis #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPashkin
reviewed
Aug 30, 2018
build_travis.sh
Outdated
| else | ||
| FEATURES=gtk_3_22_30,futures-stable | ||
| fi | ||
| elif [ "$GTK" = "3.18" ]; then | ||
| BUNDLE="gtk-3.18.1-2" | ||
| if [ "$TRAVIS_RUST_VERSION" = "nightly" ]; then | ||
| FEATURES=gtk_3_18,futures-nightly | ||
| FEATURES=gtk_3_18 |
There was a problem hiding this comment.
And please change in commented default in Cargo.toml
There was a problem hiding this comment.
If you remove futures-nightly from glib completely, then better remove it here too.
There was a problem hiding this comment.
I would like to keep this here for the time being as I plan to add it back based on 0.3 as soon as I figure out how to do that in glib's Cargo.toml
EPashkin
reviewed
Aug 30, 2018
futures 0.2 is not maintained any longer and the nightly parts don't build with the latest nightly toolchain anymore.
|
Thanks, now looks good |
|
Looks good. I'll follow what @EPashkin suggested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
futures 0.2 is not maintained any longer and the nightly parts don't
build with the latest nightly toolchain anymore.