Skip to content

Allow empty text/expression query string #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow empty text/expression query string #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1735ee
Trim string before pasting
asportnoy Aug 5, 2022
2237ba5
Use explicit undefined check for query strings
asportnoy Aug 5, 2022
7c8814a
Only use defalut value if nullish
asportnoy Aug 5, 2022
249f5cc
Remove debug
asportnoy Sep 19, 2022
9e3e9d0
Remove change from other PR
asportnoy Sep 19, 2022
747686f
Remove end line
asportnoy Sep 19, 2022
d088160
No trailing new line
asportnoy Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/src/RegExr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export default class RegExr extends EventDispatcher {
params = {};
}
if (params.engine) { this.flavor.value = params.engine; }
if (params.expression) { this.expression.value = params.expression; }
if (params.text) { this.text.value = params.text; }
if (params.expression !== undefined) { this.expression.value = params.expression; }
if (params.text !== undefined) { this.text.value = params.text; }
if (params.tool) { this.tools.value = {id:params.tool, input:params.input}; }

window.onbeforeunload = (e) => this.unsaved ? "You have unsaved changes." : null;
Expand Down
2 changes: 1 addition & 1 deletion dev/src/views/Expression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default class Expression extends EventDispatcher {
}

set value(expression) {
let regex = Utils.decomposeRegEx(expression || Expression.DEFAULT_EXPRESSION, this.delim);
let regex = Utils.decomposeRegEx(expression ?? Expression.DEFAULT_EXPRESSION, this.delim);
this.pattern = regex.source;
this.flags = regex.flags;
}
Expand Down
2 changes: 1 addition & 1 deletion dev/src/views/Text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default class Text extends EventDispatcher {
}

set value(val) {
this.editor.setValue(val || this.defaultText);
this.editor.setValue(val ?? this.defaultText);
}

get value() {
Expand Down