Repository navigation
grpc-xds/load_balancing: Cluster manager implementation. - #2884
Merged
nathanielford merged 43 commits intoOct 15, 2026
Merged
Conversation
arjan-bal
reviewed
Sep 23, 2026
…rsing to ParsedLbConfig
nathanielford
force-pushed
the
feature/cluster-manager-lb
branch
from
September 24, 2026 21:42
fdc3ac3 to
38adbed
Compare
nathanielford
marked this pull request as ready for review
September 25, 2026 00:04
dfawley
reviewed
Sep 25, 2026
dfawley
left a comment
dfawley
left a comment
Member
There was a problem hiding this comment.
I only reviewed cluster_manager - which mostly LGTM - because I believe Arjan has the full call attributes implementation.
arjan-bal
reviewed
Sep 28, 2026
Contributor
|
Please use the format |
nathanielford
changed the title
Contributor
|
Please allow reviewers to resolve their own comments. When comments are resolved preemptively, I have to manually expand each thread to verify the new changes. |
nathanielford
changed the title
arjan-bal
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation of XDS Cluster Manager
Solution
Leverages ChildManager to manage child policies. Carries functionality to parse ClusterManager-specific configuration, do the resolver fanout and picker assemblage and handles the per-rpc routing and enforcement of drops on missing/unknown attributes/clusters.
Notes