Skip to content

grpc-js: Add test for custom error code #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murgatroid99 merged 1 commit into from
Feb 13, 2025
Merged

grpc-js: Add test for custom error code #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/grpc-js/test/fixtures/test_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ message Request {
string message = 2;
int32 errorAfter = 3;
int32 responseLength = 4;
int32 code = 5;
}

message Response {
Expand Down
15 changes: 14 additions & 1 deletion packages/grpc-js/test/test-server-errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,11 @@ describe('Other conditions', () => {
const req = call.request;

if (req.error) {
const code = req.code || grpc.status.UNKNOWN;
const details = req.message || 'Requested error';

cb(
{ code: grpc.status.UNKNOWN, details } as ServiceError,
{ code, details } as ServiceError,
null,
trailerMetadata
);
Expand Down Expand Up @@ -816,6 +817,18 @@ describe('Other conditions', () => {
}
);
});

it('for a non-standard error code', done => {
client.unary(
{ error: true, code: 57 },
(err: ServiceError, data: any) => {
assert(err);
assert.strictEqual(err.code, 57);
assert.strictEqual(err.details, 'Requested error');
done();
}
);
});
});

describe('should handle server stream errors correctly', () => {
Expand Down