grpc-js: Pass channel args to LB policies with updates #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-js_lb_child_helper_channel_args
branch
from
1fa6d92 to
86e62f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the channel options argument from the
LoadBalancerconstructor and adds it to theupdateAddressListmethod, replacing theattributesargument. Resolver attributes are now added to channel options, as are any other values that need to be passed between LB policies but don't go in the LB policy config. Channel options that start with the string defined inSUBCHANNEL_ARGS_EXCLUDE_KEY_PREFIXwill not be passed to subchannel constructors or used to determine subchannel uniqueness.