Skip to content

Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error #12040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error #12040

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2bf4968
Android: Add failOnWarnings check to android build.gradle and configu…
Sangamesh1997 Apr 28, 2025
c571f77
android: added white space
Sangamesh1997 Apr 28, 2025
dbfe6d4
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 May 6, 2025
148c017
Android : added review comments point
Sangamesh1997 May 6, 2025
f9a0fde
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 May 9, 2025
85a6ba6
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 May 12, 2025
94f92f6
Android : added review comments point
Sangamesh1997 May 12, 2025
6d3f981
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 May 21, 2025
4e81d10
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 May 27, 2025
b151cb0
Added review comments points
Sangamesh1997 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ android {
versionName "1.0"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions { abortOnError true }

// fail on android lint warnings if failOnWarning is set true
lintOptions {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are doing this anyway, lintOptions is deprecated. Use lint instead. (Wait for Eric's comment on this before working)

abortOnError true
if (rootProject.hasProperty("failOnWarnings") && rootProject.failOnWarnings.toBoolean()) {
warningsAsErrors true
}
}

publishing {
singleVariant('release') {
withSourcesJar()
Expand All @@ -44,6 +52,14 @@ dependencies {
testImplementation libraries.truth
}

// Enforce -Werror on java compiler if failOnWarning is set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may remove the comments as they are self explanatory.

tasks.withType(JavaCompile).configureEach {
it.options.compilerArgs += ["-Xlint:all"]
if (rootProject.hasProperty("failOnWarnings") && rootProject.failOnWarnings.toBoolean()) {
it.options.compilerArgs += ["-Werror"]
}
}

tasks.register("javadocs", Javadoc) {
source = android.sourceSets.main.java.srcDirs
classpath += files(android.getBootClasspath())
Expand Down