Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equality and hashcode of CancelServerStreamCommand. #11785

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

benjaminp
Copy link
Contributor

In e036b1b, CancelServerStreamCommand got another field. But, its hashCode and equals methods were not updated.

In e036b1b, CancelServerStreamCommand got another field. But, its hashCode and equals methods were not updated.
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 3, 2025
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 3, 2025
@ejona86 ejona86 requested a review from larry-safran January 3, 2025 17:31
@larry-safran larry-safran merged commit bac8b32 into grpc:master Jan 3, 2025
15 of 16 checks passed
@benjaminp benjaminp deleted the cancel-server-stream-equality branch January 4, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants