xds:Move creating the retry timer in handleRpcStreamClosed to as late as possible and call close() #11776
Conversation
…possible and call `close` so that the `call` is cancelled. Also add some debug logging.
| @@ -371,6 +375,11 @@ private void notifyIfReady() { | |||
| boolean doNotify; | |||
| synchronized (onReadyLock) { | |||
| doNotify = isReady(); | |||
| if (!doNotify) { | |||
| log.log(Level.FINE, | |||
| "Transport not ready. allocated/de:{0}/{3}, sent queued: {1}, ready thresh: {2}", | |||
There was a problem hiding this comment.
This can create an immense about of logspam. It's also not at all clear what it is talking about (if you aren't looking at the line of code logs this, it is meaningless). What is this trying to achieve?
There was a problem hiding this comment.
What are you trying to achieve with this? I don't follow what it has to do with anything.
There was a problem hiding this comment.
In trying to figure out why in the interop test the onReady callback isn't being invoked I found that there is no visibility in any way into what would cause it to skip doing the notification even though the subchannel had gone into a READY state. This was trying to provide that visibility.
There was a problem hiding this comment.
"Transport not ready" is very easy to misinterpret, change it to the stream is not ready. We will need to avoid the object array creation, so first check whether FINER logging is enabled.
Call
close()instead of explicitly settingclosed = trueand callingcleanup()since that will also terminate the underlying ClientCall.Also add some debug logging.