Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ServletAdapter]: Ability remove context path when get method name #11730

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

long76
Copy link

@long76 long76 commented Dec 9, 2024

Refs: #5066

Complex application may have many war-s and do not allow monopolize root context path(/). Add ability to remove context path(usual it's war name) from application server use @WebInitParam or just override getInitParameter for parameter GrpcServlet.REMOVE_CONTEXT_PATH

requestURI = contextPath + servletPath + pathInfo

https://stackoverflow.com/a/42706412

Copy link

linux-foundation-easycla bot commented Dec 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@long76 long76 marked this pull request as draft December 9, 2024 15:02
@panchenko
Copy link
Contributor

Could you please describe the problem you are trying to solve?

@long76
Copy link
Author

long76 commented Dec 9, 2024

Could you please describe the problem you are trying to solve?

I use Wildfly 24 and need use non root context(/) for GRPC. I can use custom path for GRPC server? On GRPC clients like Insomnia and Postman i can't put localhost:8080/grpc-war in url. This MR allow use custom context for application servers like WildFly. If i will use HAProxy or something else for proxy i can get access for GRPC server on Wildfly 24 on GrpcServlet.

@panchenko
Copy link
Contributor

I can use custom path for GRPC server?

No.

Insomnia and Postman

They are not real clients, but UI tools to send arbitrary requests to server for development purposes.

@long76 long76 marked this pull request as ready for review December 11, 2024 17:20
@ejona86
Copy link
Member

ejona86 commented Dec 26, 2024

Yeah, there's not going to be clients that work with this. It sounds like you would get testing infrastructure running, but once you try to make real clients you're going to have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants