Remove java.util.logging from AsyncServletOutputStreamWriter.Log #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments suggest that this API cannot be referenced, but a new method in the interface still used it.
ejona86
reviewed
Nov 1, 2024
| @@ -88,8 +87,8 @@ final class AsyncServletOutputStreamWriter { | |||
| Logger logger = Logger.getLogger(AsyncServletOutputStreamWriter.class.getName()); | |||
| this.log = new Log() { | |||
| @Override | |||
| public boolean isLoggable(Level level) { | |||
| return logger.isLoggable(level); | |||
There was a problem hiding this comment.
I think the point was to not run this line. There can be synchronization involved here, and that could maybe mess up lincheck. So it wasn't about avoiding the loading of the dependency (that actually happens anyway, even with this change), it ways about not calling into its infrastructure.
Not that I have any more background on this than you do, but I do think it is a plausible story.
Maybe we should change the comment to say "not call java.util.logging.Logger"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments suggest that this API cannot be referenced, but a new method in the interface still used it.
It is possible that only the Logger interface itself can't be referenced for some reason, in which case this won't help - I can't seem to cause the apparent Lincheck issue from the Gradle tests.