Skip to content

Implement translated text from IAB parameter urls #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: allow-download-files-inside-iab
Choose a base branch
from
Open

Implement translated text from IAB parameter urls #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9969895
Implement the download text from IAB parameter urls
joaolourencoge Sep 25, 2025
57b303b
add no storage message and fallback to request failed if different er…
joaolourencoge Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 148 additions & 33 deletions src/android/InAppBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ public class InAppBrowser extends CordovaPlugin {
private boolean fullscreen = true;
private String[] allowedSchemes;
private InAppBrowserClient currentClient;
private String downloadInProgress = "Download in progress...";
private String downloadCompleted = "Download completed successfully";

/**
* Executes the request and returns PluginResult.
Expand Down Expand Up @@ -645,6 +647,93 @@ private boolean areDownloadsAllowed() {
}
}

/**
* Get custom download progress text from URL parameter or use default
*
* @return String
*/
private String getDownloadInProgressText() {
try {
// Get the current page URL from the WebView
String currentUrl = inAppWebView.getUrl();

if (currentUrl == null) {
return downloadInProgress;
}

Uri uri = Uri.parse(currentUrl);
String customText = uri.getQueryParameter("downloadInProgress");
return customText != null ? customText : downloadInProgress;
} catch (Exception e) {
return downloadInProgress;
}
}

/**
* Get custom download completed text from URL parameter or use default
*
* @return String
*/
private String getDownloadCompletedText() {
try {
// Get the current page URL from the WebView
String currentUrl = inAppWebView.getUrl();

if (currentUrl == null) {
return downloadCompleted;
}

Uri uri = Uri.parse(currentUrl);
String customText = uri.getQueryParameter("downloadCompleted");
return customText != null ? customText : downloadCompleted;
} catch (Exception e) {
return downloadCompleted;
}
}

/**
* Get localized error message for download failure reasons
* This will use the device's OS language settings
*
* @param reason DownloadManager failure reason
* @return String localized error message
*/
/**
* Get no storage message from URL parameter
*/
private String getNoStorageMessage() {
try {
String url = webView.getUrl();
if (url != null && url.contains("noStorageMessage=")) {
String[] parts = url.split("noStorageMessage=");
if (parts.length > 1) {
String message = parts[1].split("&")[0];
return java.net.URLDecoder.decode(message, "UTF-8");
}
}
} catch (Exception e) {
}
return "Not enough storage space";
}

/**
* Get request failed message from URL parameter
*/
private String getRequestFailedMessage() {
try {
String url = webView.getUrl();
if (url != null && url.contains("requestFailed=")) {
String[] parts = url.split("requestFailed=");
if (parts.length > 1) {
String message = parts[1].split("&")[0];
return java.net.URLDecoder.decode(message, "UTF-8");
}
}
} catch (Exception e) {
}
return "Request failed";
}

/**
* Check if the URL is a downloadable file
*
Expand Down Expand Up @@ -765,37 +854,38 @@ private void handleDownload(String url, String userAgent, String contentDisposit
request.setDestinationInExternalFilesDir(cordova.getActivity(), Environment.DIRECTORY_DOCUMENTS, filename);
}

// Enqueue download
long downloadId = manager.enqueue(request);

// Make final copy for use in inner classes
final String finalFilename = filename;

// Show persistent progress dialog
cordova.getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
showDownloadProgress();
}
});

// Register download completion listener
registerDownloadCompleteListener(downloadId, finalFilename);
// Enqueue download
long downloadId;
try {
downloadId = manager.enqueue(request);

// Show persistent progress dialog
cordova.getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
showDownloadProgress();
}
});

// Register download completion listener
registerDownloadCompleteListener(downloadId, finalFilename);
} catch (Exception e) {
// Handle cases where enqueue fails (e.g., no network)
showDownloadError(getRequestFailedMessage());
return;
}

// Also add a backup polling mechanism in case broadcast doesn't work
startDownloadPolling(downloadId, finalFilename, manager);

} catch (SecurityException e) {
// Show more helpful message
String message = "Download failed due to permissions. ";
if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.Q) {
message += "File saved to app folder instead.";
} else {
message += "File will be saved to app-specific directory.";
}
showDownloadError(message);
showDownloadError(getRequestFailedMessage());
} catch (Exception e) {
showDownloadError("Download failed: " + e.getMessage());
showDownloadError(getRequestFailedMessage());
}
}

Expand All @@ -812,8 +902,7 @@ private void showDownloadProgress() {
}

progressDialog = new android.app.ProgressDialog(cordova.getActivity());
progressDialog.setTitle("Download in progress...");
progressDialog.setMessage("Please wait...");
progressDialog.setTitle(getDownloadInProgressText());
progressDialog.setCancelable(false);
progressDialog.setIndeterminate(true);
progressDialog.show();
Expand All @@ -838,7 +927,7 @@ public void run() {
// Show simple success toast
android.widget.Toast.makeText(
cordova.getActivity(),
"Download completed successfully",
getDownloadCompletedText(),
android.widget.Toast.LENGTH_LONG
).show();

Expand All @@ -856,6 +945,7 @@ public void run() {

/**
* Dismiss progress dialog and show download error message to user
* Shows localized error message and auto-dismisses after 5 seconds
*/
private void showDownloadError(String message) {
cordova.getActivity().runOnUiThread(new Runnable() {
Expand All @@ -868,12 +958,24 @@ public void run() {
progressDialog = null;
}

// Create a simple toast notification
android.widget.Toast.makeText(
cordova.getActivity(),
"Download error: " + message,
android.widget.Toast.LENGTH_LONG
).show();
// Create an AlertDialog that auto-dismisses after 5 seconds
android.app.AlertDialog.Builder builder = new android.app.AlertDialog.Builder(cordova.getActivity());
builder.setTitle(message)
.setCancelable(true);

final android.app.AlertDialog errorDialog = builder.create();
errorDialog.show();

// Auto dismiss after 5 seconds
android.os.Handler handler = new android.os.Handler();
handler.postDelayed(new Runnable() {
@Override
public void run() {
if (errorDialog.isShowing()) {
errorDialog.dismiss();
}
}
}, 5000); // 5 seconds

// Also send event to JavaScript if needed
JSONObject obj = new JSONObject();
Expand Down Expand Up @@ -929,15 +1031,21 @@ public void onReceive(Context context, Intent intent) {
public void run() {
android.widget.Toast.makeText(
cordova.getActivity(),
"Download completed: " + title,
getDownloadCompletedText() + ": " + title,
android.widget.Toast.LENGTH_LONG
).show();
}
});
}
} else if (status == DownloadManager.STATUS_FAILED) {
int reason = (reasonIndex >= 0) ? cursor.getInt(reasonIndex) : -1;
showDownloadError("Download failed (reason: " + reason + ")");
String errorMessage;
if (reason == DownloadManager.ERROR_INSUFFICIENT_SPACE) {
errorMessage = getNoStorageMessage();
} else {
errorMessage = getRequestFailedMessage();
}
showDownloadError(errorMessage);
}
}
}
Expand Down Expand Up @@ -1007,7 +1115,7 @@ public void run() {
} else if (status == DownloadManager.STATUS_FAILED) {
LOG.e(LOG_TAG, "Polling detected failed download");
cursor.close();
showDownloadError("Download failed");
showDownloadError(getRequestFailedMessage());
return;
}
}
Expand All @@ -1019,6 +1127,13 @@ public void run() {
handler.postDelayed(this, 1000); // Poll every second
} else {
LOG.d(LOG_TAG, "Download polling timeout");
// Show error message when download times out (likely network issue)
cordova.getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
showDownloadError(getRequestFailedMessage());
}
});
}
} catch (Exception e) {
LOG.e(LOG_TAG, "Error in download polling: " + e.getMessage());
Expand Down
Loading
Loading