Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in updated spacing and container tokens #4702

Merged
merged 21 commits into from
Jan 21, 2025

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Jan 16, 2025

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Closes #4543

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 5e46c19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hpe-design-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from standardize-file-names to master January 17, 2025 22:07
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 5e46c19
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/678fe235758ef70008d22590
😎 Deploy Preview https://deploy-preview-4702--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taysea taysea requested a review from halocline January 17, 2025 22:25
Copy link
Collaborator

@halocline halocline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, rest looks good.

"codeSyntax": {}
}
}
},
"38400": {
Copy link
Collaborator

@halocline halocline Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primitive token to value pattern seems to break here. If I understand how these primitive tokens are being built up, there is a ratio of 25 between the token and value (e.g. 600 / 25 = 24, 25600 / 25 = 1024).

However, 38400 & 76800 seem to break this pattern. 38400 / 25 = 1536, not 1152 as currently defined; 76800 / 25 = 3072, not 1536.

Do we need to:

  • add 28800 --> 1152
  • modify 38400 --> 1536
  • add 51200 --> 2048
  • modify 78600 --> 3072

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes 38400 --> 1536. I don't believe we have use for 1152, 2048, or 3072.

I've adjusted 38400, but not added the others.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with omitting those for now.

We don't need the 1152 because we are just hardcoding that in the HPE theme, correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. 👍

design-tokens/tokens/primitive/primitives.default.json Outdated Show resolved Hide resolved
@halocline halocline self-requested a review January 21, 2025 18:11
@taysea taysea merged commit 1affdd5 into master Jan 21, 2025
8 of 9 checks passed
@taysea taysea deleted the update-spacing-container-tokens branch January 21, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spacing and container sizing tokens
2 participants