Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lighthouse check #4364

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove lighthouse check #4364

merged 1 commit into from
Nov 8, 2024

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Nov 8, 2024

Deploy Preview

What does this PR do?

Removing lighthouse action. It's been outdated and failing for ages (and not aligned with the values we get when running lighthouse in browser) so doesn't seem to be providing much value.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from jcfilben November 8, 2024 15:59
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 8a22a59
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/672e356ff89cea0008343c07
😎 Deploy Preview https://deploy-preview-4364--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taysea taysea merged commit a346eaa into master Nov 8, 2024
11 of 12 checks passed
@taysea taysea deleted the remove-lighthouse branch November 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant